Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/channels encryption #3789

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

osmaczko
Copy link
Contributor

@osmaczko osmaczko commented Jul 21, 2023

Introduced channel-level encryption.

  • distribute ratchet keys at both community and channel levels
  • use explicit HashRatchetGroupID in ecryption layer, instead of
    inheriting groupID from CommunityID
  • populate HashRatchetGroupID with CommunityID+ChannelID for
    channels, and CommunityID for whole community
  • hydrate channels with members; channel members are now subset of
    community members
  • include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998

@status-im-auto
Copy link
Member

status-im-auto commented Jul 21, 2023

Jenkins Builds

Click to see older builds (28)
Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ a9e29db #1 2023-07-21 13:33:40 ~2 min tests 📄log
✔️ a9e29db #1 2023-07-21 13:34:25 ~3 min linux 📦zip
✔️ a9e29db #1 2023-07-21 13:35:32 ~4 min ios 📦zip
✔️ a9e29db #1 2023-07-21 13:35:55 ~4 min android 📦aar
✖️ 3faee08 #2 2023-07-21 18:48:11 ~1 min tests 📄log
✔️ 3faee08 #2 2023-07-21 18:48:30 ~1 min linux 📦zip
✔️ 3faee08 #2 2023-07-21 18:49:55 ~3 min ios 📦zip
✔️ 3faee08 #2 2023-07-21 18:51:38 ~4 min android 📦aar
✖️ 82166bd #3 2023-07-21 19:18:00 ~1 min tests 📄log
✔️ 82166bd #3 2023-07-21 19:18:22 ~1 min linux 📦zip
✔️ 82166bd #3 2023-07-21 19:19:00 ~2 min android 📦aar
✔️ 82166bd #3 2023-07-21 19:19:51 ~2 min ios 📦zip
✖️ ebdbf7b #4 2023-07-21 19:35:36 ~48 sec tests 📄log
✔️ ebdbf7b #4 2023-07-21 19:35:49 ~1 min linux 📦zip
✔️ ebdbf7b #4 2023-07-21 19:36:25 ~1 min android 📦aar
✔️ ebdbf7b #4 2023-07-21 19:37:31 ~2 min ios 📦zip
✔️ 8df128f #5 2023-07-21 19:42:13 ~1 min linux 📦zip
✔️ 8df128f #5 2023-07-21 19:42:30 ~1 min android 📦aar
✔️ 8df128f #5 2023-07-21 19:43:49 ~3 min ios 📦zip
✖️ 8df128f #5 2023-07-21 20:04:29 ~23 min tests 📄log
✔️ 7afa312 #6 2023-07-21 19:43:49 ~1 min linux 📦zip
✔️ 7afa312 #6 2023-07-21 19:44:09 ~1 min android 📦aar
✔️ 7afa312 #6 2023-07-21 19:46:40 ~2 min ios 📦zip
✔️ 8e86295 #7 2023-07-21 19:45:32 ~1 min linux 📦zip
✔️ 8e86295 #7 2023-07-21 19:45:46 ~1 min android 📦aar
✔️ 8e86295 #7 2023-07-21 19:49:25 ~2 min ios 📦zip
✖️ 8e86295 #6 2023-07-21 20:27:28 ~22 min tests 📄log
✖️ 8e86295 #7 2023-07-24 14:15:28 ~21 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9479ebf #8 2023-07-24 14:44:17 ~2 min android 📦aar
✔️ 9479ebf #8 2023-07-24 14:44:57 ~2 min ios 📦zip
✔️ 9479ebf #8 2023-07-24 14:45:15 ~3 min linux 📦zip
✖️ 9479ebf #8 2023-07-24 15:03:38 ~21 min tests 📄log
✔️ ed8dc60 #9 2023-07-24 14:45:55 ~1 min android 📦aar
✔️ ed8dc60 #9 2023-07-24 14:46:53 ~1 min linux 📦zip
✔️ ed8dc60 #9 2023-07-24 14:47:47 ~2 min ios 📦zip
✖️ ed8dc60 #9 2023-07-24 15:24:54 ~21 min tests 📄log
✔️ ed8dc60 #10 2023-07-24 16:52:27 ~18 min tests 📄log

@osmaczko osmaczko force-pushed the feat/communities-key-distributor branch from 0cd5c2d to 9a889cc Compare July 21, 2023 18:45
@osmaczko osmaczko force-pushed the feat/channels-encryption branch 3 times, most recently from 82166bd to ebdbf7b Compare July 21, 2023 19:34
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

protocol/communities/community_encryption_key_action.go Outdated Show resolved Hide resolved
@osmaczko osmaczko force-pushed the feat/channels-encryption branch 3 times, most recently from 7afa312 to 8e86295 Compare July 21, 2023 19:44
- distribute ratchet keys at both community and channel levels
- use explicit `HashRatchetGroupID` in ecryption layer, instead of
  inheriting `groupID` from `CommunityID`
- populate `HashRatchetGroupID` with `CommunityID+ChannelID` for
  channels, and `CommunityID` for whole community
- hydrate channels with members; channel members are now subset of
  community members
- include channel permissions in periodic permissions check

closes: status-im/status-desktop#10998
@osmaczko osmaczko force-pushed the feat/channels-encryption branch 2 times, most recently from 9479ebf to ed8dc60 Compare July 24, 2023 14:42
@osmaczko osmaczko merged commit 5bc5dae into feat/communities-key-distributor Jul 24, 2023
@osmaczko osmaczko deleted the feat/channels-encryption branch July 24, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants