-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/channels encryption #3789
Merged
osmaczko
merged 1 commit into
feat/communities-key-distributor
from
feat/channels-encryption
Jul 24, 2023
Merged
Feat/channels encryption #3789
osmaczko
merged 1 commit into
feat/communities-key-distributor
from
feat/channels-encryption
Jul 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (28)
|
osmaczko
force-pushed
the
feat/communities-key-distributor
branch
from
July 21, 2023 18:45
0cd5c2d
to
9a889cc
Compare
osmaczko
force-pushed
the
feat/channels-encryption
branch
3 times, most recently
from
July 21, 2023 19:34
82166bd
to
ebdbf7b
Compare
jrainville
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
osmaczko
force-pushed
the
feat/channels-encryption
branch
3 times, most recently
from
July 21, 2023 19:44
7afa312
to
8e86295
Compare
- distribute ratchet keys at both community and channel levels - use explicit `HashRatchetGroupID` in ecryption layer, instead of inheriting `groupID` from `CommunityID` - populate `HashRatchetGroupID` with `CommunityID+ChannelID` for channels, and `CommunityID` for whole community - hydrate channels with members; channel members are now subset of community members - include channel permissions in periodic permissions check closes: status-im/status-desktop#10998
osmaczko
force-pushed
the
feat/channels-encryption
branch
2 times, most recently
from
July 24, 2023 14:42
9479ebf
to
ed8dc60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced channel-level encryption.
HashRatchetGroupID
in ecryption layer, instead ofinheriting
groupID
fromCommunityID
HashRatchetGroupID
withCommunityID+ChannelID
forchannels, and
CommunityID
for whole communitycommunity members
closes: status-im/status-desktop#10998