Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CommunityEncryptionKeyActions and its evaluation logic #3765

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat: add CommunityEncryptionKeyActions and its evaluation logic #3765

merged 1 commit into from
Jul 20, 2023

Conversation

osmaczko
Copy link
Contributor

Added utility that evaluates necessary encryption key actions based on community changes.

part of: status-im/status-desktop#10998

@status-im-auto
Copy link
Member

status-im-auto commented Jul 17, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (21)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ ff14b3f #1 2023-07-17 11:00:56 ~2 min tests 📄log
✔️ ff14b3f #1 2023-07-17 11:01:02 ~2 min linux 📦zip
✔️ ff14b3f #1 2023-07-17 11:02:54 ~4 min android 📦aar
✔️ 97b3568 #2 2023-07-17 11:08:58 ~1 min android 📦aar
✔️ 97b3568 #2 2023-07-17 11:10:16 ~2 min linux 📦zip
✖️ 97b3568 #2 2023-07-17 11:32:45 ~25 min tests 📄log
✔️ f8f7989 #3 2023-07-17 11:18:11 ~1 min linux 📦zip
✔️ f8f7989 #3 2023-07-17 11:18:31 ~1 min android 📦aar
✖️ f8f7989 #3 2023-07-17 11:56:28 ~23 min tests 📄log
✖️ f8f7989 #4 2023-07-17 12:19:14 ~21 min tests 📄log
✔️ af9eecd #4 2023-07-17 17:28:17 ~1 min linux 📦zip
✔️ af9eecd #4 2023-07-17 17:31:23 ~4 min android 📦aar
✖️ af9eecd #5 2023-07-17 17:49:47 ~22 min tests 📄log
✔️ 9de6436 #5 2023-07-20 06:56:46 ~1 min linux 📦zip
✔️ 9de6436 #5 2023-07-20 06:57:13 ~1 min android 📦aar
✔️ 9de6436 #5 2023-07-20 06:58:41 ~3 min ios 📦zip
✔️ 9de6436 #6 2023-07-20 07:14:27 ~18 min tests 📄log
✔️ e79e0ae #6 2023-07-20 07:39:32 ~1 min linux 📦zip
✔️ e79e0ae #6 2023-07-20 07:39:53 ~1 min android 📦aar
✔️ e79e0ae #6 2023-07-20 07:40:51 ~2 min ios 📦zip
✖️ e79e0ae #7 2023-07-20 07:42:20 ~4 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7a45373 #7 2023-07-20 08:07:13 ~1 min linux 📦zip
✔️ 7a45373 #7 2023-07-20 08:07:34 ~1 min android 📦aar
✔️ 7a45373 #7 2023-07-20 08:08:43 ~2 min ios 📦zip
✖️ 7a45373 #8 2023-07-20 08:09:29 ~3 min tests 📄log
✔️ 2416ffa #8 2023-07-20 08:31:46 ~1 min linux 📦zip
✔️ 2416ffa #8 2023-07-20 08:32:07 ~1 min android 📦aar
✔️ 2416ffa #8 2023-07-20 08:33:12 ~2 min ios 📦zip
✔️ 2416ffa #9 2023-07-20 08:50:43 ~20 min tests 📄log

@osmaczko osmaczko force-pushed the feat/encryption-action branch 2 times, most recently from 97b3568 to f8f7989 Compare July 17, 2023 11:16
jrainville
jrainville reviewed Jul 17, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Nice tests too.
I just had one question

protocol/communities/community_encryption_key_action.go Show resolved Hide resolved
@osmaczko osmaczko force-pushed the feat/encryption-action branch from f8f7989 to af9eecd Compare July 17, 2023 17:26
@osmaczko osmaczko force-pushed the feat/encryption-action branch from af9eecd to 9de6436 Compare July 20, 2023 06:55
@osmaczko osmaczko requested review from jrainville and mprakhov July 20, 2023 07:00
@osmaczko osmaczko force-pushed the feat/encryption-action branch 2 times, most recently from e79e0ae to 7a45373 Compare July 20, 2023 08:05
@osmaczko
feat: add CommunityEncryptionKeyActions and its evaluation logic
2416ffa 
Added utility that evaluates necessary encryption key actions based on
community changes.

part of: status-im/status-desktop#10998
@osmaczko osmaczko force-pushed the feat/encryption-action branch from 7a45373 to 2416ffa Compare July 20, 2023 08:30
jrainville
jrainville approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@osmaczko osmaczko merged commit d9df8b6 into develop Jul 20, 2023
@osmaczko osmaczko deleted the feat/encryption-action branch July 20, 2023 15:17
@osmaczko osmaczko mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mprakhov mprakhov mprakhov approved these changes

@jrainville jrainville jrainville approved these changes

@0x-r4bbit 0x-r4bbit Awaiting requested review from 0x-r4bbit

@cammellos cammellos Awaiting requested review from cammellos

@Samyoul Samyoul Awaiting requested review from Samyoul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@osmaczko @status-im-auto @jrainville @mprakhov