-
Notifications
You must be signed in to change notification settings - Fork 985
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fixes #16310 We used to reply on `react-native cli` and would pass a `--device` flag to deploy the debug variant of `iOS` app on connected `iPhone`. `react-native cli` under the hood uses `ios-deploy` library to achieve this functionality. This showed many weird issues, specifically in locating connected devices and failures at build step with ambiguous error messages. This commit fixes it by using our custom script `run-ios-devices.sh` which does not rely on `ios-deploy`. We use `libimobiledevice` to identify `UDID` of a connected `iPhone`. We use `xcrun devicectl device install app` and `xcrun devicectl device process launch` to install and launch the app. This works well with `Xcode 15` and `iOS 17.x`. We can now remove `ios-deploy` from `iOS` shell and `nix` overlay. - connect your iPhone to your Laptop via a cable - `make run-clojure` - `make run-ios-device` (note: no need to pass device name now)
- Loading branch information
1 parent
3c6b38a
commit 8962eb0
Showing
4 changed files
with
78 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
#!/usr/bin/env bash | ||
set -euo pipefail | ||
set -m # needed to access jobs | ||
|
||
GIT_ROOT=$(cd "${BASH_SOURCE%/*}" && git rev-parse --show-toplevel) | ||
|
||
# We run Metro in background while calling adb. | ||
cleanupMetro() { | ||
pkill -f run-metro.sh | ||
rm -f metro-server-logs.log | ||
} | ||
|
||
# Using function gives a neater jobspec name. | ||
runMetro() { | ||
nohup "${GIT_ROOT}/scripts/run-metro.sh" 2>&1 \ | ||
| tee metro-server-logs.log | ||
} | ||
|
||
waitForMetro() { | ||
set +e # Allow grep command to fail in the loop. | ||
TIMEOUT=5 | ||
echo "Waiting for Metro server..." >&2 | ||
while ! grep -q "Welcome to Metro" metro-server-logs.log; do | ||
echo -n "." >&2 | ||
sleep 1 | ||
if ((TIMEOUT == 0)); then | ||
echo -e "\nMetro server timed out, exiting" >&2 | ||
set -e # Restore errexit for rest of script. | ||
return 1 | ||
fi | ||
((TIMEOUT--)) | ||
done | ||
set -e # Restore errexit for rest of script. | ||
} | ||
|
||
# find the first connected iPhone's UUID | ||
DEVICE_UUID=$(idevice_id -l) | ||
|
||
# Check if any device is connected | ||
if [ -z "$DEVICE_UUID" ]; then | ||
echo "No connected iPhone device detected." | ||
exit 1 | ||
else | ||
echo "Connected iPhone UDID: $DEVICE_UUID" | ||
fi | ||
|
||
BUILD_DIR="${GIT_ROOT}/build" | ||
XCRUN_LOG_DIR="${GIT_ROOT}/build/XcrunLog" | ||
|
||
#iOS build of debug scheme | ||
xcodebuild -workspace "ios/StatusIm.xcworkspace" -configuration Debug -scheme StatusIm -destination id="$DEVICE_UUID" -derivedDataPath "${BUILD_DIR}" | xcbeautify | ||
|
||
APP_PATH="${BUILD_DIR}/Build/Products/Debug-iphoneos/StatusIm.app" | ||
|
||
# Install on the connected device | ||
xcrun devicectl device install app --device "$DEVICE_UUID" "$APP_PATH" --json-output "$XCRUN_LOG_DIR" | ||
|
||
# Extract installationURL | ||
INSTALLATION_URL=$(jq -r '.result.installedApplications[0].installationURL' "$XCRUN_LOG_DIR") | ||
|
||
# launch the app and put it in background | ||
xcrun devicectl device process launch --no-activate --verbose --device "$DEVICE_UUID" "$INSTALLATION_URL" --json-output "$XCRUN_LOG_DIR" | ||
|
||
# Extract background PID of status app | ||
STATUS_PID=$(jq -r '.result.process.processIdentifier' "$XCRUN_LOG_DIR") | ||
|
||
trap cleanupMetro EXIT ERR INT QUIT | ||
runMetro & | ||
waitForMetro | ||
|
||
# now that metro is ready, resume the app from background | ||
xcrun devicectl device process resume --device "$DEVICE_UUID" --pid "$STATUS_PID" | ||
|
||
# bring metro job to foreground | ||
fg 'runMetro' |