Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement all variants for QR code #16329

Closed
ilmotta opened this issue Jun 20, 2023 · 7 comments · Fixed by #17221
Closed

Implement all variants for QR code #16329

ilmotta opened this issue Jun 20, 2023 · 7 comments · Fixed by #17221
Assignees
@ulisesmac
Labels
design-system feature feature requests

Comments

@ilmotta
Copy link
Contributor

ilmotta commented Jun 20, 2023 •
edited by ulisesmac
Loading

Feature

Implement the "Show QR code" option for any given community channel. See Figma > Sharing for Mobile > Share from Status

Update:

Implement all variants for the QR code component:
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=17928-209739&mode=design&t=mOWDt2exmZ2Al72p-4
image
@ilmotta ilmotta added the feature feature requests label Jun 20, 2023
@ulisesmac ulisesmac mentioned this issue Aug 24, 2023
Closed
@ulisesmac ulisesmac self-assigned this Aug 24, 2023
@ulisesmac
Copy link
Contributor

@ilmotta for the wallet we need to implement all variants, so I'm taking this issue and edited the description to cover all of them 👍

@ulisesmac ulisesmac changed the title Implement Community Channel option: Show QR code Implement all variantos for QR code Aug 24, 2023
@ulisesmac ulisesmac changed the title Implement all variantos for QR code Implement all variants for QR code Aug 24, 2023
@ilmotta
Copy link
Contributor Author

ilmotta commented Aug 24, 2023

@ilmotta for the wallet we need to implement all variants, so I'm taking this issue and edited the description to cover all of them 👍

Just saw your conversation in Discord @ulisesmac. Thanks for updating the issue too.

@ulisesmac ulisesmac mentioned this issue Sep 7, 2023
Merged
@ulisesmac ulisesmac removed their assignment Sep 21, 2023
@ulisesmac
Copy link
Contributor

I'm removing my assignment in this issue since it's going to be addressed in status-go.

@siddarthkay Maybe after having these avatars implemented in status-go you could take this issue and add the proper URLs to fetch them. wdyt?

@siddarthkay siddarthkay self-assigned this Sep 21, 2023
@siddarthkay
Copy link
Contributor

Hi @ulisesmac Thank you!
yes I'll use this issue to track and log my progress.

@J-Son89
Copy link
Contributor

J-Son89 commented Oct 2, 2023

@ulisesmac, @siddarthkay is this issue needed still?

@siddarthkay
Copy link
Contributor

Hi @J-Son89 : yep lets keep this one open till work gets merged into develop

@ulisesmac ulisesmac assigned ulisesmac and unassigned siddarthkay Oct 2, 2023
@ulisesmac
Copy link
Contributor

Yes! I'll take it again. I'm working on it 👍

ulisesmac added a commit that referenced this issue Oct 8, 2023
@ulisesmac
[#16329] QR code variants (#17221)
1abd1e9 
* Rename wallet-user-avatar's `:color` prop to `:customization-color`
* Refactor QR code component and implement all variants
  - Improve preview screen
* Update QR code usages
* Remove `status-im2.common.qr-code-viewer.view/qr-code-view` component
to keep only one implementation.
* Remove the node dependency:
  "qrcode": "^1.4.1"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
design-system feature feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#16329] QR code variants status-im/status-mobile
4 participants
@ilmotta @J-Son89 @siddarthkay @ulisesmac