Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Wallet Legacy" and "Wallet Multichain" variants in the "Share QR Code" component #17023

Closed
smohamedjavid opened this issue Aug 16, 2023 · 5 comments · Fixed by #17736
Closed

Implement "Wallet Legacy" and "Wallet Multichain" variants in the "Share QR Code" component #17023

smohamedjavid opened this issue Aug 16, 2023 · 5 comments · Fixed by #17736
Assignees
@ulisesmac
Labels
design-system feature feature requests shell

Comments

@smohamedjavid
Copy link
Member

Feature

Implement the following variants in the Share QR Code component:

  • Wallet Legacy
  • Wallet Multichain

Designs

Link to Figma

Acceptance Criteria:
@smohamedjavid
Copy link
Member Author

Depends on #17026

@ulisesmac ulisesmac self-assigned this Aug 23, 2023
@ulisesmac
Copy link
Contributor

ulisesmac commented Aug 23, 2023 •
edited
Loading

I'll start working on this issue since

already has a PR

@ulisesmac
Copy link
Contributor

ulisesmac commented Aug 24, 2023 •
edited
Loading

Depends on:

I'm solving it and will take this one once it's ready

@ulisesmac ulisesmac removed their assignment Sep 21, 2023
@ulisesmac ulisesmac self-assigned this Oct 17, 2023
@smohamedjavid smohamedjavid mentioned this issue Oct 20, 2023
Closed
@OmarBasem
Copy link
Contributor

OmarBasem commented Oct 20, 2023 •
edited
Loading

Hey @ulisesmac,

Have you started working on this one already? I started working on this but did not notice this issue. If you already started then I can discard my branch.

@ulisesmac
Copy link
Contributor

Hey @ulisesmac,

Have you started working on this one already? I started working on this but did not notice this issue. If you already started then I can discard my branch.

Hey @OmarBasem

Yes, I already started. I'm planning to create a PR soon 👍

@OmarBasem OmarBasem mentioned this issue Oct 23, 2023
Closed
@ulisesmac ulisesmac mentioned this issue Oct 25, 2023
Merged
ulisesmac added a commit that referenced this issue Oct 31, 2023
@ulisesmac
[#17023] Share qr code variants (#17736)
4a874ce 
* Align docstring

* Create share-qr-code component

* Remove empty style file

* Implement common.share-qr-code including call to media server

* Add share-qr-code preview screen

* Use share-qr-code component in shell's share screen

* Add tests and some fixes
yevh-berdnyk pushed a commit that referenced this issue Dec 8, 2023
@ulisesmac @yevh-berdnyk
[#17023] Share qr code variants (#17736)
6ae5cf9 
* Align docstring

* Create share-qr-code component

* Remove empty style file

* Implement common.share-qr-code including call to media server

* Add share-qr-code preview screen

* Use share-qr-code component in shell's share screen

* Add tests and some fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulisesmac ulisesmac

Labels
design-system feature feature requests shell
Projects
Do not use - tasks moved to unified Desktop / Mobile Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#17023] Share qr code variants status-im/status-mobile
4 participants
@Parveshdhull @smohamedjavid @OmarBasem @ulisesmac