Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet - Update default name for watched address when adding it #18416

Closed
Tracked by #18575
smohamedjavid opened this issue Jan 6, 2024 · 3 comments · Fixed by #18683
Closed
Tracked by #18575

Wallet - Update default name for watched address when adding it #18416

smohamedjavid opened this issue Jan 6, 2024 · 3 comments · Fixed by #18683
Assignees
Labels
feature feature requests low-prio wallet: Create account all issues for the create account page of the wallet

Comments

@smohamedjavid
Copy link
Member

smohamedjavid commented Jan 6, 2024

Feature Issue

When adding a new watched address, the placeholder should be Watched address (x) where x is the total number of watched addresses in the profile + 1.

Design

Figma Link

Acceptance Criteria

  • The placeholder name for the watched address should display Watched address (x)
  • The placeholder name for a generated account should display Account (y) where y is the total number of accounts (not watched) in the profile + 1.
  • the actual name should be empty and the user has to input some value themselves
@Rende11
Copy link
Collaborator

Rende11 commented Jan 29, 2024

I would like to implement it

@Rende11
Copy link
Collaborator

Rende11 commented Jan 30, 2024

@smohamedjavid I'm bit confused with +1. As I understand i should be something like this:

action/state account name
user have only default account account name -> Account (1)
add one more account Account (2)
add watched address Watched address (1)
add watched address again Watched address (2)
add usual account Account (3)

Right?
Account number should be in parentheses?

@smohamedjavid
Copy link
Member Author

Right?

You are right @Rende11. The table makes the requirements understandable much simpler.

Account number should be in parentheses?

No, The account number should not be in parentheses.

Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 1, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 2, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 2, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 7, 2024
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 13, 2024
…atus-im#18416

Update subs

Fix tests

Update subs

Update account placeholders

Add note
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 13, 2024
…atus-im#18416

Update subs

Fix tests

Update subs

Update account placeholders

Add note

Fix test
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 13, 2024
…atus-im#18416

Update subs

Fix tests

Update subs

Update account placeholders

Add note

Fix test
Rende11 added a commit to Rende11/status-mobile that referenced this issue Feb 15, 2024
…atus-im#18416

Update subs

Fix tests

Update subs

Update account placeholders

Add note

Fix test
J-Son89 pushed a commit that referenced this issue Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests low-prio wallet: Create account all issues for the create account page of the wallet
Development

Successfully merging a pull request may close this issue.

3 participants