Update default name for account and watched address #18416 #18683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (44)
|
J-Son89
requested review from
smohamedjavid,
J-Son89 and
OmarBasem
and removed request for
smohamedjavid
|
seems the component tests are failing btw |
OmarBasem
reviewed
Feb 1, 2024
src/status_im/contexts/wallet/add_address_to_watch/confirm_address/view.cljs
Outdated
Show resolved
Hide resolved
J-Son89
approved these changes
Feb 1, 2024
Rende11
force-pushed
the
address-default-name
branch
from
95d4bf3 to
103642a
Compare
OmarBasem
approved these changes
Feb 2, 2024
Rende11
force-pushed
the
address-default-name
branch
from
103642a to
a9e0fe6
Compare
Rende11
force-pushed
the
address-default-name
branch
from
a9e0fe6 to
3ee8270
Compare
Rende11
force-pushed
the
address-default-name
branch
from
3ee8270 to
8b16e4e
Compare
Simulator.Screen.Recording.-.iPhone.13.-.2024-02-07.at.23.34.31.mp4 |
|
You can't slide button after changing Simulator.Screen.Recording.-.iPhone.13.-.2024-02-12.at.21.49.23.mp4 |
Rende11
force-pushed
the
address-default-name
branch
3 times, most recently
from
7dd2330 to
98549c2
Compare
|
@status-im/mobile-qa - when testing this feature, please note some details. We discussed with designers and it should be the default placeholder with this naming convention here. The user is expected to enter a name, for that reason the slide button should be disabled when the name is empty, however there is an issue with disabling the slide button so @Rende11 did not disable it here. |
56% of end-end tests have passedFailed tests (20)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMerged:
Expected to fail tests (1)Click to expandClass TestCommunityOneDeviceMerged:
Passed tests (27)Click to expandClass TestActivityMultipleDevicePRTwo:
Class TestDeepLinksOneDevice:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
|
|
Hi @Rende11 ! Thanks for your PR! ISSUE 1: The only thing from my side is to ask design team regarding font color as I can see here not the color used by you (for both: accounts and watch only) |
Francesca-G
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
@mariia-skrypnyk you're correct, the color of the placeholder doesn't match design.
I can also confirm the slider issue @J-Son89 mentioned, as well as other issues with it, as commented here
Adding follow up required 👍
|
Thanks @Francesca-G, @mariia-skrypnyk if it's okay we will handle these issues separately 👍 |
…atus-im#18416 Update subs Fix tests Update subs Update account placeholders Add note Fix test
Rende11
force-pushed
the
address-default-name
branch
from
4541559 to
0faa16b
Compare
|
ISSUE 1 followup |
|
@mariia-skrypnyk - here is the issue for disabling the slide button - #18894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18416
Summary
Upd:
This PR updates placeholders for account and watched address when creating.
Review and testing notes
disabled?state)Before and after comparison
Simulator.Screen.Recording.-.iPhone.13.-.2024-02-13.at.15.59.49.mp4
status: ready