Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] Show values in the user's currency #8027

Closed
flexsurfer opened this issue Apr 24, 2019 · 34 comments · Fixed by #9063
Closed

[Wallet] Show values in the user's currency #8027

flexsurfer opened this issue Apr 24, 2019 · 34 comments · Fixed by #9063
Assignees
@StatusSceptre
Labels
feature feature requests

Comments

@flexsurfer
Copy link
Member

flexsurfer commented Apr 24, 2019 •
edited by rachelhamlin
Loading

Currently, the transaction overview shows only the token being transacted. It should also include the user's currency.

FIGMA LINK

Expected behavior
image

Actual behavior
image
@flexsurfer flexsurfer self-assigned this Apr 24, 2019
This was referenced Apr 24, 2019
Closed
Closed
@flexsurfer flexsurfer changed the title [Wallet] Show values in user currency [Wallet] Show values in the user's currency Apr 24, 2019
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2019
Closed
@flexsurfer flexsurfer removed their assignment May 7, 2019
@flexsurfer flexsurfer added the feature feature requests label May 13, 2019
@flexsurfer flexsurfer mentioned this issue Jun 6, 2019
Merged
@rachelhamlin rachelhamlin added v1 and removed v1 audit labels Jul 23, 2019
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Workers have applied to start work.

These users each claimed they can complete the work by 4 weeks, 1 day from now.
Please review their action plans below:

1) vic-en has applied to start work (Funders only: approve worker | reject worker).

Hi, I will study the code carefully and integrate any free or opensource currency conversion api to ensure it display user currency as requested. I await your approval so I can begin work immediately.

Learn more on the Gitcoin Issue Details page.

@rachelhamlin
Copy link
Contributor

You're approved @vic-en! Welcome. @yenda @flexsurfer which api do we use for currency conversion elsewhere?

@yenda
Copy link
Contributor

yenda commented Sep 9, 2019

There is no need to interact with the API, there is already a :prices subscription to get the prices

@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vic-en
Copy link

vic-en commented Sep 11, 2019

I've started work on this bounty. I think @yenda has a point. There wouldn't be a need to use external currency conversion api. I'll just figure out how to access that interface.

@vic-en
Copy link

vic-en commented Sep 13, 2019

Hi, just to update. I've also made great progress towards showing the user currency. I'm still familiarizing myself with the code and layout to ensure nothing more or less happens than showing user's currency alone.

@rachelhamlin
Copy link
Contributor

That's great @vic-en! Should we expect a PR this week?

@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vic-en
Copy link

vic-en commented Sep 19, 2019

That's great @vic-en! Should we expect a PR this week?

yes, this weekend
I broke my installation by accident but I fixed it today so I'll test the code again

@gitcoinbot
Copy link

@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@vic-en
Copy link

vic-en commented Sep 24, 2019

@rachelhamlin , so sorry I'm replying late. I've having problem with my development workspace lately. I have lost several important data and this project is also part of it and I'm afraid I may not be able to continue this project soon to complete the bounty. However, I'm ready to give all possible info and will be stating the necessary to complete the bounty to whoever will take it up soon.

The steps to complete the bounty is as follow:

  1. The major view file to make the user currency appear is here
  2. The lines in the above file to effect the converted currency are majorly between lines 216 and 260
  3. Also cryptocompare.com currency conversion API is already part of the project and should be included at the beginning of the file like this

[status-im.utils.prices :as prices]

and called like this

prices/get-prices [from to mainnet? on-success on-error chaos-mode?]

  1. In addition, a money formatting library has been coded also and should also be added like this

[status-im.utils.money :as money]

and called like this

money/fiat-amount-value [amount-str from to prices]

In order not to waste more of time, I would stop work on this bounty on your confirmation if you want to re-assign to another developer. I'll keep checking back on the issue to know if anymore help is needed. Also, I wouldn't mind a little tip.

@acolytec3
Copy link
Contributor

If @vic-en is stepping back, @rachelhamlin, I'd be interested in picking this one up (since it looks like there weren't any other applicants on it). I've also applied to work on #8443 and this one is a precursor to that so would be happy to do both at once. Let me know!

@acolytec3 acolytec3 mentioned this issue Sep 27, 2019
Merged
@acolytec3
Copy link
Contributor

@rachelhamlin Just checking in on this. I've applied on gitcoin and haven't officially been accepted to work on this yet though my PR is close to done (pending final review from the devs/designers).

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Oct 2, 2019 •
edited
Loading

Hey! So sorry about that @acolytec3. I just approved you 😬We're a bit bottlenecked, but thank you so much for the PR.

@acolytec3
Copy link
Contributor

Thanks! Just submitted my PR on gitcoin. Just waiting on the other two reviewers to provide feedback or approve.

@rachelhamlin
Copy link
Contributor

Excellent, nicely done @acolytec3! I'll try to give it a whirl myself tomorrow and get payment to you ASAP (we typically wait for PRs to be merged but recognize there is a long wait for that right now).

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by:

  1. @acolytec3

@StatusSceptre please take a look at the submitted work:

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 2, 2019 •
edited
Loading

Thanks! Are there any other issues coming up for bounties soon? Would love to take a crack at another one if so.

@rachelhamlin
Copy link
Contributor

rachelhamlin commented Oct 3, 2019 •
edited
Loading

@acolytec3 awesome! Unfurling of URLs in chat can wait; I just saw you applied on Gitcoin. I haven't bountied any of these yet, but they're blockers for our v1 release, do any of them catch your eye?

#8938
#8960
#8818

Also - I can pay for this bounty once the devs review once more. Both on holiday today. Will ask for a pass tomorrow. :)

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 3, 2019 via email

@rachelhamlin
Copy link
Contributor

🙌 Bounty processing! I invited you @acolytec3.

@acolytec3
Copy link
Contributor

@rachelhamlin PR was just merged :-)

@acolytec3
Copy link
Contributor

@rachelhamlin I got a notification from gitcoin about a tip but it referenced a bounty I didn't worked on. Was it supposed to be for this one or #8938?

@rachelhamlin
Copy link
Contributor

Whoops, not quite sure how I managed that. I underpaid you as well @acolytec3. It was for this one.

I tipped you 60 DAI on #8135 and meant to 80 DAI pay for this one, #8027.

I'll send over another 20 on this one and close it out on Gitcoin. Sorry about that!

@rachelhamlin
Copy link
Contributor

Jokes. I can't pay out less than the full 80 DAI for this one.

I'll add 20 DAI as tip for your work on #8938 instead @acolytec3.

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 7, 2019 via email •
edited
Loading

@rachelhamlin rachelhamlin mentioned this issue Oct 7, 2019
Closed
@rachelhamlin
Copy link
Contributor

Indeed there are more in the queue for you, @acolytec3!

What about one of these bugs?

Wallet balance refresh not working properly
Recent stickers not populating

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 7, 2019 via email

@acolytec3 acolytec3 mentioned this issue Oct 9, 2019
Closed
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Cancelled

The funding of 80.0 SAI (80.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StatusSceptre StatusSceptre

Labels
feature feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add currency conversions for signing sheet - Fixes #8027 acolytec3/status-react
7 participants
@yenda @flexsurfer @rachelhamlin @acolytec3 @gitcoinbot @vic-en @StatusSceptre