-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Wallet] Show values in the user's currency #8027
Comments
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 80.0 DAI (80.0 USD @ $1.0/DAI) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Workers have applied to start work. These users each claimed they can complete the work by 4 weeks, 1 day from now. 1) vic-en has applied to start work (Funders only: approve worker | reject worker). Hi, I will study the code carefully and integrate any free or opensource currency conversion api to ensure it display user currency as requested. I await your approval so I can begin work immediately. Learn more on the Gitcoin Issue Details page. |
You're approved @vic-en! Welcome. @yenda @flexsurfer which api do we use for currency conversion elsewhere? |
There is no need to interact with the API, there is already a |
@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
I've started work on this bounty. I think @yenda has a point. There wouldn't be a need to use external currency conversion api. I'll just figure out how to access that interface. |
Hi, just to update. I've also made great progress towards showing the user currency. I'm still familiarizing myself with the code and layout to ensure nothing more or less happens than showing user's currency alone. |
That's great @vic-en! Should we expect a PR this week? |
@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
yes, this weekend |
@vic-en Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@rachelhamlin , so sorry I'm replying late. I've having problem with my development workspace lately. I have lost several important data and this project is also part of it and I'm afraid I may not be able to continue this project soon to complete the bounty. However, I'm ready to give all possible info and will be stating the necessary to complete the bounty to whoever will take it up soon. The steps to complete the bounty is as follow:
and called like this
and called like this
In order not to waste more of time, I would stop work on this bounty on your confirmation if you want to re-assign to another developer. I'll keep checking back on the issue to know if anymore help is needed. Also, I wouldn't mind a little tip. |
If @vic-en is stepping back, @rachelhamlin, I'd be interested in picking this one up (since it looks like there weren't any other applicants on it). I've also applied to work on #8443 and this one is a precursor to that so would be happy to do both at once. Let me know! |
@rachelhamlin Just checking in on this. I've applied on gitcoin and haven't officially been accepted to work on this yet though my PR is close to done (pending final review from the devs/designers). |
Hey! So sorry about that @acolytec3. I just approved you 😬We're a bit bottlenecked, but thank you so much for the PR. |
Thanks! Just submitted my PR on gitcoin. Just waiting on the other two reviewers to provide feedback or approve. |
Excellent, nicely done @acolytec3! I'll try to give it a whirl myself tomorrow and get payment to you ASAP (we typically wait for PRs to be merged but recognize there is a long wait for that right now). |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 80.0 DAI (80.0 USD @ $1.0/DAI) has been submitted by: @StatusSceptre please take a look at the submitted work:
|
Thanks! Are there any other issues coming up for bounties soon? Would love to take a crack at another one if so. |
@acolytec3 awesome! Unfurling of URLs in chat can wait; I just saw you applied on Gitcoin. I haven't bountied any of these yet, but they're blockers for our v1 release, do any of them catch your eye? Also - I can pay for this bounty once the devs review once more. Both on holiday today. Will ask for a pass tomorrow. :) |
I'll take #8938! I think I have an instinct on how to turn it around and
therefore more manageable for me since I'm relatively new to this CLJS
game, ;-).
I'm still kind of interested in trying out that unfurling one so might go
ahead and work on it some once I get 8938 done since it presents a good
opportunity to learn more about how interoperability with Javascript works
(since I've never touched that).
…On Thu, Oct 3, 2019, 11:46 AM Rachel Hamlin ***@***.***> wrote:
@acolytec3 <https://github.com/acolytec3> awesome! Unfurling of URLs in
chat can wait; I just saw you applied on Gitcoin. I haven't bountied any of
these yet, but they're blockers for our v1 release, do any of them catch
your eye?
#8938 <#8938>
#8960 <#8960>
#8818 <#8818>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8027>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEENFXFPZYTCKRVPU4QOAUDQMYHT3ANCNFSM4HICHFYQ>
.
|
🙌 Bounty processing! I invited you @acolytec3. |
@rachelhamlin PR was just merged :-) |
@rachelhamlin I got a notification from gitcoin about a tip but it referenced a bounty I didn't worked on. Was it supposed to be for this one or #8938? |
Whoops, not quite sure how I managed that. I underpaid you as well @acolytec3. It was for this one. I tipped you 60 DAI on #8135 and meant to 80 DAI pay for this one, #8027. I'll send over another 20 on this one and close it out on Gitcoin. Sorry about that! |
Jokes. I can't pay out less than the full 80 DAI for this one. I'll add 20 DAI as tip for your work on #8938 instead @acolytec3. |
@rachelhamlin No worries! Was just a little confused when I saw the linked
issue on the gitcoin notification.
Given that I've finished #8938, would love to keep working if there are
other issues that need immediate attention. Anything I can look at?
…On Mon, Oct 7, 2019, 8:04 AM Rachel Hamlin ***@***.***> wrote:
Whoops, not quite sure how I managed that. I underpaid you as well
@acolytec3 <https://github.com/acolytec3>. It was for this one.
I tipped you 60 DAI on #8135
<#8135> and meant to 80
DAI pay for this one, #8027
<#8027>.
I'll send over another 20 on this one and close it out on Gitcoin. Sorry
about that!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8027>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEENFXCOMZIXPH4BHKKQJ73QNMQV5ANCNFSM4HICHFYQ>
.
|
Indeed there are more in the queue for you, @acolytec3! What about one of these bugs? Wallet balance refresh not working properly |
#8951 sounds cool. I'll take it!
…On Mon, Oct 7, 2019, 8:16 AM Rachel Hamlin ***@***.***> wrote:
Indeed there are more in the queue for you, @acolytec3
<https://github.com/acolytec3>!
What about one of these bugs?
Wallet balance refresh not working properly
<#8951>
Recent stickers not populating
<#8937>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8027>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEENFXA6HCZEZV5DVQXQAMDQNMSCFANCNFSM4HICHFYQ>
.
|
Issue Status: 1. Open 2. Cancelled The funding of 80.0 SAI (80.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter
|
Currently, the transaction overview shows only the token being transacted. It should also include the user's currency.
FIGMA LINK
Expected behavior
Actual behavior
The text was updated successfully, but these errors were encountered: