Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't scan wallet QR for transaction due to "network doesn't match" error #8960

Closed
churik opened this issue Sep 10, 2019 · 14 comments · Fixed by #9209
Closed

Can't scan wallet QR for transaction due to "network doesn't match" error #8960

churik opened this issue Sep 10, 2019 · 14 comments · Fixed by #9209

Comments

@churik
Copy link
Member

churik commented Sep 10, 2019

Description

Type: Bug

Summary: instead of current network id is shown when scanning QR to set recipient in a transaction screen.

Expected behavior

QR is scanned

Actual behavior

IMG_5FEC68E8E54B-1

Reproduction

  • Open Status
  • Go to wallet, select account
  • Tap on "Send"
  • scan valid QR (mainnet - mainnet)

Additional Information

@acolytec3
Copy link
Contributor

@churik I'd be interested in taking a stab at resolving this one. Is the Android camera permissions bug fixed yet? I don't have macos so can only do it if so.

@churik
Copy link
Member Author

churik commented Oct 7, 2019

Hello @acolytec3 !
Android issue with QR code is fixed, for IOS we have #8997

@acolytec3
Copy link
Contributor

Cool, I'm working on #8951 at the moment but will look at this one next if it's not already being worked by someone else.

@acolytec3
Copy link
Contributor

@rachelhamlin I think I've got #8951 finished up at this point (pending final review from @yenda and QA), can I start on this one? I'm able to reproduce the bug locally and ready to dig in. Alternatively, are there any other high priority items for v1 I could help with?

@acolytec3
Copy link
Contributor

@rachelhamlin Any chance you can setup a bounty for this one on gitcoin so I can submit work o it? The PR has been merged so it's all done at this point. :-)

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it.

@StatusSceptre
Copy link
Member

@acolytec3 this has been reserved for you, go ahead an apply and we'll pay it out.

@gitcoinbot
Copy link

gitcoinbot commented Oct 17, 2019

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 5 days from now.
Please review their action plans below:

1) acolytec3 has started work.

Already done the work so will submit the PR here.

Learn more on the Gitcoin Issue Details page.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 60.0 DAI (60.0 USD @ $1.0/DAI) has been submitted by:

  1. @acolytec3

@StatusSceptre please take a look at the submitted work:


@acolytec3
Copy link
Contributor

@StatusSceptre work submitted, thanks!

@acolytec3
Copy link
Contributor

@StatusSceptre Quick bump to remind this PR has been approved and merged already.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @acolytec3.

@StatusSceptre
Copy link
Member

Oops! I'm sorry about that @acolytec3. It's paid :)

@acolytec3
Copy link
Contributor

acolytec3 commented Oct 22, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants