-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Multi-Account] Design touch-ups for account explorer + wallet UI #8447
Comments
@andmironov for the above items: can you please check if there's more detailed specification to be added? |
I'd be happy to provide the details if needed, but for now, every item of the list above seems straightforward to me. The only thing is
I think it might better be a separate issue since it's not super important and it (at least to me) seems to require a lot of implementation effort? Correct me if I am wrong. anyway, @errorists can you share the link to the prototype you've made? |
After the discussion on this post and in Status, I'm going to remove the Pinterest style transition from this issue and make it its own. Not sure it is possible with React Native. |
@bitsikka hey, so a couple pointers, for the scroll transition you can recycle the toolbar you did for the profile. I might have used a different behaviour when prototyping this (the text interpolates its size based on scroll position) but that's not really required, it can use the same go under the toolbar, appear smaller above it like you did for profile, consistency and all :) as for the pinteresty transition, I'm 100% sure it's possible, it's a custom React Navigation transition |
wonderful! :) appreciate your thoughtfulness. Although I've been studying and I am positive, Text scaling transform/interpolation is possible, it will be wise to maintain consistency.
Thank you for the awesome resource. I will master it and apply it here. I knew you wouldn't prototype something not possible :). After all, engineering is also art/design, and you are yourself excellent at it. I figure, were it not for the implementation language, you would've long jumped in and fixed it :) Will do my best to do justice to spec, meanwhile being mindfully reasonable about performance, as well as time. I also had a hunch that there is untapped creative potential in React Navigation that will be useful here(and other places). On to study. Let me just take this opportunity to say, what I've been meaning to say, that, your and design/ux team work is simply top notch, to the extent of every sub-pixel and their movement being accounted for, with concern for overall UX; And I am glad to have the opportunity to work on implementing them. The magic of "minor" details like alignment/typography/interaction-feedback when it all comes together, is simply very pleasing, satisfying and amazing UX - in other words subconsciously mind-blowing! :) I will ping you in status or here when I have questions. |
@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
|
Help! It seems that I am the only one having this problem.
Have not been able to move forward an inch since Thursday |
@bitsikka there should be an error in the logs, could you check it in safari dev console? |
|
@bitsikka https://facebook.github.io/react-native/docs/debugging#safari-developer-tools Enable Develop menu in Safari: Preferences → Advanced → Select "Show Develop menu in menu bar" |
oh.. ddg'd and found that doc :) doing it now.. hold on |
got this
|
have you tried to clean project and rebuild again? |
@bitsikka i have the same error in develop, on it, hold on |
I have, multiple times. Did |
Just to confirm I'm facing the same issue after rebase with latest develop. |
@bitsikka you can also install https://www.npmjs.com/package/react-native-log-ios and just run |
Good to know. Thanks! @siphiuel |
I'm good to go 😄 |
@bitsikka please rebase , should work |
Best to wait for #8776 to be merged, - it has improved animation/component-structure for Meanwhile,
|
@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot I am working indirectly on this. |
@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@gitcoinbot |
@bitsikka Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done @bitsikka due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
Fixes copy update in #8447 In the UI we want to refer to a watch only address as `address` instead of `account`. Interactions with an address are limited compared to an account in wallet. e.g. there is no option to send assets from this account as Status wallet does not have the key to sign for transactions.
Fixes copy update in #8447 In the UI we want to refer to a watch only address as `address` instead of `account`. Interactions with an address are limited compared to an account in wallet. e.g. there is no option to send assets from this account as Status wallet does not have the key to sign for transactions. Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@bitsikka catching up here. Do I understand correctly that this issue is on pause while you are working on Topbar #8981 and were waiting for #8776 to be merged? Do you have an ETA on when you might get around to this issue? If it's plus 2 weeks we might see if someone else can pick this one up, but obviously not if you're 90% there. |
@hesterbruikman yes we are in total sync
|
hey everyone! seems like this issue has grown too big and is on a long pause and has changed it's initial subject over time :-) . Does anyone think it would be helpful opening a new topbar-specific issue (and maybe another one about the account card transition from @errorists 's prototype) and closing this one? These two un-crossed tasks from the initial issue description are no more relevant
|
Yup, sounds good. I think this one covers account card transition @andmironov? #8896 And as for the topbar, we have this issue, which is still open—although there is a first iteration complete. |
Issue Status: 1. Open 2. Cancelled The funding of 60.0 SAI (60.0 USD @ $1.0/SAI) attached to this issue has been cancelled by the bounty submitter
|
Description
Type: Feature
Summary: There are some to-dos remaining from PR 8425:
The correct on scroll behaviour of the navigation bar is not implemented yetN/A nowThe horizontal scroll container is clipping its content on the left sideN/A nowPinterest style transition- SEPARATE ISSUE: Pinterest style transitions for account explorer #8896The single card should have the right padding at 16- DONEMonospace (supported after onboarding PR merge)- DONECopy updates:- DONEAdd a watch account
>Add a watch address
The text was updated successfully, but these errors were encountered: