Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fx macro on ios #8953

Merged
merged 1 commit into from
Sep 9, 2019
Merged

fix fx macro on ios #8953

merged 1 commit into from
Sep 9, 2019

Conversation

flexsurfer
Copy link
Member

No description provided.

@flexsurfer flexsurfer requested a review from a team as a code owner September 9, 2019 11:13
@flexsurfer flexsurfer self-assigned this Sep 9, 2019
@auto-assign auto-assign bot removed the request for review from a team September 9, 2019 11:13
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

Copy link
Contributor

@yenda yenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a redscreens.README file with the debugging process:

Stacktrace:

13:25:22, Requiring: hi-base32
13:25:23, Possible Unhandled Promise Rejection (id: 0):
TypeError: undefined is not an object (evaluating 'status_im.utils.handlers.register_handler_fx')
eval code
eval@[native code]
asyncImportScripts$@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:200728:21
tryCatch@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:26567:23
invoke@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:26742:32
tryCatch@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:26567:23
invoke@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:26643:30
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:26653:21
tryCallOne@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3725:16
http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:3826:27
_callTimer@http://localhost:8081/index.bundle?platform=ios&dev=true&minify=false:28405:17
_callImmediatesPass@http://localhost:8081/index.bundle?pla<…>

Cause:

  • stacktrace mentions register_handler_fx,
  • common cause is when requires have been cleaned up and a require of status-im.utils.handlers namespace was removed because it looked like it was unused but was actually used through a fx/defn macro

Solution:
go through known faulty commit looking for deleted requires

@status-im-auto
Copy link
Member

status-im-auto commented Sep 9, 2019

Jenkins Builds

Click to see older builds (3)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 841370c #1 2019-09-09 11:24:48 ~10 min ios 📦 ipa
✔️ 841370c #1 2019-09-09 11:26:55 ~12 min android 📦 apk
✔️ 841370c #1 2019-09-09 11:27:07 ~13 min android-e2e 📦 apk
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 807dff3 #2 2019-09-09 11:38:07 ~9 min android 📦 apk
✔️ 807dff3 #2 2019-09-09 11:38:29 ~10 min android-e2e 📦 apk
✔️ 807dff3 #2 2019-09-09 11:39:01 ~10 min ios 📦 ipa
✔️ 05a63a7 #4 2019-09-09 11:56:18 ~10 min android 📦 apk
✔️ 05a63a7 #4 2019-09-09 11:56:18 ~10 min ios 📦 ipa
✔️ 05a63a7 #4 2019-09-09 11:56:34 ~10 min android-e2e 📦 apk

@flexsurfer
Copy link
Member Author

@yenda done

Copy link
Contributor

@yenda yenda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I like TROUBLESHOOTING good name!

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants