Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Connect & get paid" to "Chat & transact" in "ens-welcome-point-3-title" #8717

Closed
annadanchenko opened this issue Aug 7, 2019 · 10 comments · Fixed by #10343
Closed

Comments

@annadanchenko
Copy link

annadanchenko commented Aug 7, 2019

Problem

There is string "Connect & get paid" in ens welcome screen that can mislead user that he/she can be paid if connect with other users. Please, change it to "Chat & transact" as it's more fair. Agreed with @rachelhamlin

String to change:
"ens-welcome-point-3-title" in https://github.com/status-im/status-react/blob/develop/translations/en.json

@annadanchenko annadanchenko changed the title Change "Connect & get paid" to "Chat & transact" for "ens-welcome-point-3-title" Change "Connect & get paid" to "Chat & transact" in "ens-welcome-point-3-title" Aug 7, 2019
@hesterbruikman
Copy link
Contributor

There is actually a full copy update for this screen that was out of scope of PR earlier: https://www.figma.com/file/TNCyHKtR3sx5EL6YznFWUa4O/Profile?node-id=2317%3A50

ENS copy

@yenda
Copy link
Contributor

yenda commented Oct 15, 2019

Point 2 is even less clear on the right it says ETH address in the title and talks about chat key. It is actually doing both you wallet address and chat key

@hesterbruikman
Copy link
Contributor

@yenda Agree, that copy doesn't make sense:S

What about:
Simplify your addresses
Chat with people using an easy to read and share name: myname.stateofus.eth

To make sure I understand correctly, if I'm using another wallet like Gnosis safe (random, but they were integrating ENS). And I send funds to yenda.stateofus.eth, where do those funds end up?

  • The account of the key we use for Whisper, and don't offer you access to in Status wallet yet
  • The account of the key you used to purchase your ENS name

cc @errorists

@hesterbruikman
Copy link
Contributor

hesterbruikman commented Oct 22, 2019

Just realized the above doesn't make sense for point 2 either as it basically repeats point 1. How about the following @yenda @rachelhamlin @errorists

  1. Readable chat key
    Your chat key becomes an easy to read and shareable name: myname.stateofus.eth.

  2. Show your name in Status
    Control your privacy by using your ENS name in chat instead of your random 3-word name (e.g. @vitalik94 instead of Breezy Tall Elephant).

  3. 10 SNT to register
    Register once to keep the name forever. After 1 year you can release the name and get your SNT back.

@ already own a username?

Still struggling with 1. I realize it is also an address, but we explicitly decided not to treat it as such, for example also not surfacing it in your wallet unless you manually add it when we allow to do so at some point.

@rachelhamlin
Copy link
Contributor

Hmm, in your most recent suggestion, 1 and 2 are still speaking to the same benefit @hesterbruikman. Why not call out the fact that it can also be used as a wallet address?

  1. Customize your display name
    An ENS name can replace your random 3-word name in chat. Be @yourname instead of Breezy Tall Elephant.

  2. Simplify your ETH address
    You can receive funds to your easy-to-share ENS name rather than your hexadecimal hash (0x...).

  3. 10 SNT to register
    Register once to keep the name forever. After 1 year you can release the name and get your SNT back.

@hesterbruikman
Copy link
Contributor

Sorry I dropped off here! This looks better! Few notes:

  • I think we'd better go for 1. Customize your name in chat so we get rid of the display name terminology
  • Major benefit is Receiving transactions in chat. Based on earlier convs this week and talking to @errorists.
  1. Customize your display name
    An ENS name can replace your random 3-word name in chat. Be @yourname instead of Breezy Tall Elephant.

  2. Simplify your ETH address
    You can receive funds to your easy-to-share ENS name rather than your hexadecimal hash (0x...).

  3. Instant transactions in chat
    Others can send you funds in chat without having to ask for your wallet address.

  4. 10 SNT to register
    Register once to keep the name forever. After 1 year you can release the name and get your SNT back.

wdyt? Believe I can update this myself if we all agree.

@rachelhamlin
Copy link
Contributor

I think you mean...

1. Customize your name in chat no? :) Or even 1. Customize your chat name

And as for #3, that's a good point.

I think because it only applies to scenarios in which you are requesting/receiving, I might title it, 3. Receive transactions in chat or even 3. Receive transactions freely (although we do not have plans to add an address list back to wallet yet, so this might be too vague)

3. Receive transactions in chat
Others can send funds to your ENS wallet in one simple step.
3. Receive transactions in chat
Others can send funds to your ENS wallet without any action on your part.
3. Receive transactions in chat
Others can send funds to your ENS wallet without asking for your address.

Perhaps? I think I'm being too picky. They all work! Go for whatever change you feel is best @hesterbruikman :)

@hesterbruikman
Copy link
Contributor

Thanks @rachelhamlin Great points! I'll take this last set and will make a final call based on what they look like on screen.

@hesterbruikman
Copy link
Contributor

@yenda Looking to update the copy, but they are now 5 points instead of 4.
1 2 3 4 @

where it was
1 2 3 @

Can you take a look to make sure:
ens-welcome-point-4-title shows 4 instead of @
ens-welcome-point-x and ens-welcome-point-x-title shows a @
(this would be a new 5th point but I'd rather not number it as the prefix shouldn't be a number but an @)

  1. Customize your chat name
    An ENS name can replace your random 3-word name in chat. Be @yourname instead of Breezy Tall Elephant.

  2. Simplify your ETH address
    You can receive funds to your easy-to-share ENS name rather than your hexadecimal hash (0x...).

  3. Receive transactions in chat
    Others can send you funds via chat in one simple step.

  4. 10 SNT to register
    Register once to keep the name forever. After 1 year you can release the name and get your SNT back.

@. Already own a username?
You can verify and add any usernames you own in the next steps.

@rachelhamlin I'd opt to leave out ENS wallet although I ideally also want to include some way of saying you would receive transactions in chat on the address you use to register your ENS name. I cannot find a way to describe it without creating confusion around wallets, addresses, etc... Better solution would be to add a label to Account info (to be implemented post-V1) to indicate that the account address is the ENS controller. cc @errorists

Also, @yenda I think it'd might be cool if a chat transaction can include the fact that it was a chat transaction as well as for a regular transaction to include a typed message. Transactions are too impersonal... #futuremusic #kudosintegration

@errorists
Copy link
Contributor

errorists commented Jan 27, 2020

I updated the copy in designs to what @hesterbruikman suggested above.
@rachelhamlin how about we try and squeeze this one in before the release, it's all text updates and an additional bullet point.

@yenda yenda self-assigned this Apr 15, 2020
yenda pushed a commit that referenced this issue Apr 15, 2020
english only
needs work for translations
yenda pushed a commit that referenced this issue Apr 16, 2020
english only
needs work for translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants