-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Connect & get paid" to "Chat & transact" in "ens-welcome-point-3-title" #8717
Comments
There is actually a full copy update for this screen that was out of scope of PR earlier: https://www.figma.com/file/TNCyHKtR3sx5EL6YznFWUa4O/Profile?node-id=2317%3A50 |
Point 2 is even less clear on the right it says ETH address in the title and talks about chat key. It is actually doing both you wallet address and chat key |
@yenda Agree, that copy doesn't make sense:S What about: To make sure I understand correctly, if I'm using another wallet like Gnosis safe (random, but they were integrating ENS). And I send funds to yenda.stateofus.eth, where do those funds end up?
cc @errorists |
Just realized the above doesn't make sense for point 2 either as it basically repeats point 1. How about the following @yenda @rachelhamlin @errorists
@ already own a username? Still struggling with 1. I realize it is also an address, but we explicitly decided not to treat it as such, for example also not surfacing it in your wallet unless you manually add it when we allow to do so at some point. |
Hmm, in your most recent suggestion, 1 and 2 are still speaking to the same benefit @hesterbruikman. Why not call out the fact that it can also be used as a wallet address?
|
Sorry I dropped off here! This looks better! Few notes:
wdyt? Believe I can update this myself if we all agree. |
I think you mean...
And as for #3, that's a good point. I think because it only applies to scenarios in which you are requesting/receiving, I might title it,
Perhaps? I think I'm being too picky. They all work! Go for whatever change you feel is best @hesterbruikman :) |
Thanks @rachelhamlin Great points! I'll take this last set and will make a final call based on what they look like on screen. |
@yenda Looking to update the copy, but they are now 5 points instead of 4. where it was Can you take a look to make sure:
@. Already own a username? @rachelhamlin I'd opt to leave out Also, @yenda I think it'd might be cool if a chat transaction can include the fact that it was a chat transaction as well as for a regular transaction to include a typed message. Transactions are too impersonal... #futuremusic #kudosintegration |
I updated the copy in designs to what @hesterbruikman suggested above. |
english only needs work for translations
english only needs work for translations
Problem
There is string "Connect & get paid" in ens welcome screen that can mislead user that he/she can be paid if connect with other users. Please, change it to "Chat & transact" as it's more fair. Agreed with @rachelhamlin
String to change:
"ens-welcome-point-3-title" in https://github.com/status-im/status-react/blob/develop/translations/en.json
The text was updated successfully, but these errors were encountered: