Remove ens name from local database #10134
Conversation
Pull Request Checklist
|
Jenkins Builds
|
|
@vkjr so it only partially fixes the issue? because the issue says |
|
@flexsurfer, correct. I just wrote a comment in the original issue to clarify if we need calling a transaction on registrar. As far as I understand there is no appropriate function in a contract that would stop name resolving without its releasing. |
src/status_im/ens/core.cljs
Outdated
| (fx/defn remove-username | ||
| {:events [::remove-username]} | ||
| [{:keys [db] :as cofx} name] | ||
| (let [names (get-in db [:multiaccount :usernames] []) |
There was a problem hiding this comment.
indentation is a bit weird here, it should be either one space after each binding form or all expressions should be aligned
|
hey @vkjr what's the status of this PR? |
|
@andremedeiros @vkjr what we gonna do with this one? probably we need to finish it? |
|
@jakubgs why? |
|
Was caught in the repo branch cleanup. Can be reopened. |
|
Thx for the ping. |
|
What's up with this? |
|
Small request - could you please rebase to latest master so this commit b5fda12 gets included? This means we aren't running E2E tests on eth.prod cluster anymore, and since this happens on every push, the impact is quite big. This ensures we have more accurate metrics going forward from Jul 1 onward, which would be awesome. See https://discuss.status.im/t/user-growth-and-retention/1782 for more |
|
this one seems dead |
fixes #8497
Summary
Added option to remove ENS name from phone.
Design notes
Removing name doesn't require contract transactions, so existing figma designs not fully applicable.
Platforms
Steps to test
status: ready