-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENS] Remove name flow #8497
Comments
There are two conditions where the ENS Usernames can be released:
For both cases, the function to be called is the following:
|
Its a Blockchain Fact that "usernames can be released", i.e. is the rules of the contract, which at user application level should result into update of UI of all users that are currently looking to that username. The tracking could be done by blockchain events, so all participants of the network update their interface in response to the same event. We should have a specified flow for the ENS Root, when it have an updated event at ENS Root event When a user makes public their username in a public chat, multiple users will be tracking that username events. The event tracking happens after the username check (so they have to be checked only once and updated through events), an alternative would be users subscribing through graphql (like thegraph). Notice that users that added contacts by a username should also probably be tracking their contacts, however to don't consume much data this could be done on request by the user. Users not looking (not interested on) a username released should not be notified. |
However, as a quick path to solve this issue:I. REMOVE USERNAME II. RELEASE USERNAME a. is true when RELEASE USERNAME should call It fires the event Glossary:labelHash = keccak256(<username>) For further discussion:
|
@rachelhamlin, @3esmit, @flexsurfer, I've created a PR where |
The goal of this issue was to remove the user's Status chat key from the ENS name. What is meant by local user data? @3esmit is it true that we can not remove chat key from registration without releasing the name entirely? |
By "local user data" I mean information about ens name stored locally on user's phone. If we remove it, user won't see his name among available ones. But others still can resolve it. |
i think you should be able to remove public key and wallet address from name |
so we just need to call contract and set public key to empty string |
@vkjr just pinging on this - any thoughts re: Andrey's response? |
@rachelhamlin, thanks for pinging! @flexsurfer, could you please point me to the function in a contract that should be called? I'm not fully understand it. |
@yenda could you help with that, how do we set public key for ens name ? |
ping @yenda |
Problem
Need to build remove username flow, after v1 cut.
Removing a username should:
The text was updated successfully, but these errors were encountered: