Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use image clock when updating profile images to cause re-render #21830

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seanstrom
Copy link
Member

@seanstrom seanstrom commented Dec 16, 2024

Attention

cc @alwx


fixes #21787

Summary

  • This PR attempts to fix an issue with account images not re-rendering after updating the profile image.
    • Currently this PR fixes the issue by associating a clock value to the identity images that are returned by status-go, because for some reason the clocks are defaulted to 0.
    • Likely we'll need to update status-go to populate the image clocks before forwarding the results.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • Profile images

Steps to test

WIP

Before and after screenshots comparison

After Changes on iOS

Screen.Recording.2024-12-12.at.09.29.39.mov

status: ready

@seanstrom seanstrom requested a review from alwx December 16, 2024 15:50
@seanstrom seanstrom self-assigned this Dec 16, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Dec 16, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9d1d6c6 #1 2024-12-16 15:55:48 ~5 min tests 📄log
✔️ 9d1d6c6 #1 2024-12-16 15:58:33 ~8 min ios 📱ipa 📲
✔️ 9d1d6c6 #1 2024-12-16 16:00:12 ~9 min android-e2e 🤖apk 📲
✔️ 9d1d6c6 #1 2024-12-16 16:00:26 ~9 min android 🤖apk 📲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: CONTRIBUTOR
Development

Successfully merging this pull request may close these issues.

Profile photo is not updated until re-login when it is not empty
2 participants