Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT SQUASH Meta wallet transaction history #8228

Merged
merged 8 commits into from
May 23, 2019
Merged

DO NOT SQUASH Meta wallet transaction history #8228

merged 8 commits into from
May 23, 2019

Commits on May 23, 2019

  1. [feature] use subscriptions for tokens 

    - removes fetching of last 100000 blocks of token transfers from
the wallet pull loop
- fetches the last 100000 blocks of token transfers at startup
- replaces pulling by subscriptions to ethlogs for token transfers
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f5c18ae View commit details
    Browse the repository at this point in the history

  2. [feature] use new block signal to get new transactions 

    - remove the transaction fetching loop entirely to rely only on subscription
for live transactions and token transfer updates
- fetch token transfers history via etherscan API to lift the 100000 blocks
limit on token transfers history

- inbound token transfers are catched via a filter on ethlogs
- outbound token transfers and other transactions are catched by filtering
transaction in current block that have the wallet address as to or from field
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b274ed9 View commit details
    Browse the repository at this point in the history

  3. [refactor] transaction details

    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    f1b8ba8 View commit details
    Browse the repository at this point in the history

  4. [refactor] transaction history and filters

    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    2cd26c5 View commit details
    Browse the repository at this point in the history

  5. [performance] improve wallet update performances 

    `wallet-autoconfig-token` is a very expensive call on mainnet
because it checks the balance of every known token.

it is called:
- when wallet is refreshed by pulling
- when user goes on any wallet screen

this PR changes that by:
- calling it only when the wallet is initialized and there is no
visible-token configuration

it only calls update-wallet when a new transaction arrives
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    89680f4 View commit details
    Browse the repository at this point in the history

  6. [refactoring] remove web3, clean up wallet effects 

    - introduce json-rpc namespace, which provides `call` and `eth-call`,
a generic way of calling a json-rpc method taking care of conversions
and error handling
- remove web3 usage from wallet
- clean up effects, reducing the amount of computations when login in
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    fc4c772 View commit details
    Browse the repository at this point in the history

  7. [refactor] remove ethereum call and call-params 

    - use `json-rpc/eth-call` and `json-rpc/eth-transaction-call`
everywhere
- move all conversions to abi-spec
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    b6fecd4 View commit details
    Browse the repository at this point in the history

  8. [fix] always show tokens that have a balance 

    - temporary fix before visible assets are fixed
- the problem is that you can't hide an asset with the way it currently
works, it will come back every time as long as there is a balance for it

Signed-off-by: yenda <eric@status.im>
    yenda committed May 23, 2019
    Configuration menu
    Copy the full SHA
    4103591 View commit details
    Browse the repository at this point in the history