DO NOT SQUASH Meta wallet transaction history #8228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
yenda
force-pushed
the
meta/wallet-transaction-history
branch
from
8d41cbb
to
4593918
Compare
Jenkins BuildsClick to see older builds (86)
|
yenda
force-pushed
the
meta/wallet-transaction-history
branch
3 times, most recently
from
cabc51c
to
c10b790
Compare
yenda
force-pushed
the
meta/wallet-transaction-history
branch
2 times, most recently
from
0bb2b84
to
60caa4c
Compare
flexsurfer
approved these changes
May 20, 2019
dmitryn
approved these changes
May 20, 2019
yenda
requested review from
antdanchenko,
churik,
jakubgs and
a team
as code owners
yenda
force-pushed
the
meta/wallet-transaction-history
branch
from
a395be0
to
5279a68
Compare
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (48)Click to expand |
|
Great work! I had a quick look; these are some observations.
|
|
@flexsurfer pls pls tag me for a PR review whenever you're doing UI work 🙏
|
|
what has changed:
|
Perfect. So wallet update = new tx received, missed block. Would not want to see tokens I had removed reappear in that case. What about when I update Status though? Will it autodetect all tokens then? |
can you file a bug for that describing the expected behavior? I will fix it in a next PR, this is already a bug in develop atm.
|
100% of end-end tests have passedPassed tests (49)Click to expand |
yenda
changed the title
|
@annadanchenko is it ok to merge now? |
yes, thanks for waiting! |
added 4 commits
May 23, 2019 10:30
- removes fetching of last 100000 blocks of token transfers from the wallet pull loop - fetches the last 100000 blocks of token transfers at startup - replaces pulling by subscriptions to ethlogs for token transfers
- remove the transaction fetching loop entirely to rely only on subscription for live transactions and token transfer updates - fetch token transfers history via etherscan API to lift the 100000 blocks limit on token transfers history - inbound token transfers are catched via a filter on ethlogs - outbound token transfers and other transactions are catched by filtering transaction in current block that have the wallet address as to or from field
yenda
force-pushed
the
meta/wallet-transaction-history
branch
from
fd81b83
to
5cd7b0c
Compare
added 3 commits
May 23, 2019 10:44
`wallet-autoconfig-token` is a very expensive call on mainnet because it checks the balance of every known token. it is called: - when wallet is refreshed by pulling - when user goes on any wallet screen this PR changes that by: - calling it only when the wallet is initialized and there is no visible-token configuration it only calls update-wallet when a new transaction arrives
- introduce json-rpc namespace, which provides `call` and `eth-call`, a generic way of calling a json-rpc method taking care of conversions and error handling - remove web3 usage from wallet - clean up effects, reducing the amount of computations when login in
- use `json-rpc/eth-call` and `json-rpc/eth-transaction-call` everywhere - move all conversions to abi-spec
yenda
force-pushed
the
meta/wallet-transaction-history
branch
from
5cd7b0c
to
4d5445d
Compare
- temporary fix before visible assets are fixed - the problem is that you can't hide an asset with the way it currently works, it will come back every time as long as there is a balance for it Signed-off-by: yenda <eric@status.im>
yenda
force-pushed
the
meta/wallet-transaction-history
branch
from
4d5445d
to
4103591
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a compilation of the reviewed wallet PRs so that they can be tested at once
fixes #8151
#8184 Feature/token transaction signals
part of #8151
the wallet pull loop
#8221 Feature/transaction signals
for live transactions and token transfer updates
limit on token transfers history
transaction in the current block that have the wallet address as
toorfromfield#8224 Refactor/transaction details
#8230 Refactor transaction history
#8231 Improve wallet update performances
wallet-autoconfig-tokenis a very expensive call on mainnet because it checks the balance of every known token. it is called:This PR changes that by:
#8232 Remove web3 and clean up wallet effects
callandeth-call,a generic way of calling a json-rpc method taking care of conversions
and error handling
#8233 Remove call-params usage
json-rpc/eth-callandwallet/eth-transaction-calleverywhereThe goal of this PR is to unify the way we interact with contracts, so that future improvements can be made and impact all the callees.
json-rpc/eth-callis for read only calls andwallet/eth-transaction-callis for transnational calls.Testing
When testing it is important to compare to what the situation is in develop. If things are not perfect but still equal or slightly improved compare to develop, we should treat them as bugs that I will fix asap in separate PRs, but this one is already very big and sets up the basis for faster future improvements of the wallet by cleaning up all the crap.
I tested all of the following points on Android emulator and One Plus 5T over the different PR, I will test again once build is available for the global rebase and merge.
Areas to be tested for improvements:
Areas to be tested for regressions:
Bandwidth consumption
I made the following experiment on Android:
satoshi document engage inflict goddess auction rule unfair bid next buddy shystatus: ready