Feature/transaction signals #8221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
yenda
force-pushed
the
feature/transaction-signals
branch
2 times, most recently
from
1adf195
to
2ad6956
Compare
Jenkins BuildsClick to see older builds (24)
|
yenda
force-pushed
the
feature/transaction-signals
branch
from
2ad6956
to
8232dd6
Compare
yenda
force-pushed
the
feature/transaction-signals
branch
2 times, most recently
from
fde33d3
to
34409c5
Compare
✔️ status-react/prs/ios/PR-8221#5 🔹 ~23 min 🔹 fde33d3 🔹 📦 ios package |
yenda
force-pushed
the
feature/transaction-signals
branch
from
34409c5
to
3c34d61
Compare
yenda
force-pushed
the
feature/token-transaction-signals
branch
from
f9a126e
to
e10d59e
Compare
- remove the transaction fetching loop entirely to rely only on subscription for live transactions and token transfer updates - fetch token transfers history via etherscan API to lift the 100000 blocks limit on token transfers history - inbound token transfers are catched via a filter on ethlogs - outbound token transfers and other transactions are catched by filtering transaction in current block that have the wallet address as to or from field
yenda
force-pushed
the
feature/transaction-signals
branch
from
3c34d61
to
e672c7a
Compare
|
@siphiuel @flexsurfer @jeluard please review |
vitvly
approved these changes
May 17, 2019
flexsurfer
approved these changes
May 17, 2019
98% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (48)Click to expand |
|
@yenda
And also I by mistake tested #8224 instead of this PR, so issues are here: #8224 (comment) |
|
@churik testing #8224 is fine it's the next after this one, thanks for the feedback I'll take care of it today.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8151
remove the transaction fetching loop entirely to rely only on subscriptions
for live transactions and token transfer updates
fetch token transfers history via etherscan API to lift the 100000 blocks
limit on token transfers history
inbound token transfers are caught via a filter on ethlogs
outbound token transfers and other transactions are caught by filtering
transaction in the current block that have the wallet address as
toorfromfieldTests
This affects the transaction history. It should also affect the transaction messages in chat (they should update more frequently, not test yet).
Tested on Android:
status: ready