Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/token transaction signals #8184

Closed
wants to merge 1 commit into from
Closed

Feature/token transaction signals #8184

wants to merge 1 commit into from

Conversation

yenda
Copy link
Contributor

@yenda yenda commented May 10, 2019 •
edited by 0xc1c4da
Loading

part of #8151

  • removes fetching of last 100000 blocks of token transfers from
    the wallet pull loop
  • fetches the last 100000 blocks of token transfers at startup
  • replaces pulling by subscriptions to ethlogs for token transfers

Testing

Impacts: ERC20 token transfers list (not token transfers themselves, only the refresh rate of their history)

Tested on Android:

  • receiving and sending STT and ETHro transactions on account satoshi document engage inflict goddess auction rule unfair bid next buddy shy

Expected behavior:

  • when sending and receiving token transactions, they should appear slightly faster than usual in the transaction list.
  • the transaction details don't update without refreshing the transaction list yet, this is done in the next PR where regular transactions will be live updated as well.

status: ready

@status-github-bot
Copy link

status-github-bot bot commented May 10, 2019 •
edited by yenda
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-im-auto
Copy link
Member

status-im-auto commented May 10, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (27)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f87783c #1 2019-05-10 17:30:43 ~4 min windows 📄 log
❌ f87783c #1 2019-05-10 17:32:26 ~6 min macos 📄 log
❌ f87783c #1 2019-05-10 17:32:44 ~6 min android 📄 log
❌ f87783c #1 2019-05-10 17:33:15 ~6 min linux 📄 log
❌ 344b027 #2 2019-05-10 17:36:20 ~4 min ios 📄 log
❌ 344b027 #2 2019-05-10 17:37:08 ~5 min macos 📄 log
❌ b2431aa #3 2019-05-10 17:44:44 ~7 min android-e2e 📄 log
❌ f63bf24 #4 2019-05-10 17:46:04 ~38 sec android-e2e 📄 log
❌ f63bf24 #4 2019-05-10 17:47:19 ~1 min linux 📄 log
✔️ f63bf24 #4 2019-05-10 18:02:01 ~16 min windows 📦 exe
✔️ f63bf24 #4 2019-05-10 18:03:24 ~17 min macos 📦 dmg
✔️ f63bf24 #4 2019-05-10 18:10:57 ~25 min ios 📦 ipa
✔️ f63bf24 #4 2019-05-10 18:13:19 ~27 min android 📦 apk
✔️ f63bf24 #5 2019-05-10 19:12:37 ~16 min linux 📦 App
❌ f63bf24 #5 2019-05-10 19:13:11 ~17 min android-e2e 📄 log
✔️ 72a3c1c #7 2019-05-15 20:44:40 ~15 min linux 📦 App
✔️ 72a3c1c #6 2019-05-15 20:48:17 ~18 min windows 📦 exe
✔️ 72a3c1c #6 2019-05-15 20:48:36 ~19 min macos 📦 dmg
✔️ 72a3c1c #6 2019-05-15 20:54:40 ~25 min android 📦 apk
✔️ 72a3c1c #7 2019-05-15 20:54:59 ~25 min android-e2e 📦 apk
✔️ 72a3c1c #6 2019-05-15 20:56:58 ~27 min ios 📦 ipa
✔️ 111bc0e #7 2019-05-15 22:29:55 ~19 min android 📦 apk
✔️ 111bc0e #7 2019-05-15 22:30:10 ~19 min macos 📦 dmg
✔️ 111bc0e #8 2019-05-15 22:34:29 ~23 min android-e2e 📦 apk
✔️ 111bc0e #7 2019-05-15 22:37:23 ~26 min ios 📦 ipa
✔️ 111bc0e #8 2019-05-15 22:38:34 ~27 min linux 📦 App
✔️ 111bc0e #7 2019-05-15 22:38:48 ~28 min windows 📦 exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f9a126e #9 2019-05-16 12:09:54 ~15 min android-e2e 📦 apk
✔️ f9a126e #8 2019-05-16 12:13:49 ~19 min macos 📦 dmg
✔️ f9a126e #9 2019-05-16 12:13:52 ~19 min linux 📦 App
✔️ f9a126e #8 2019-05-16 12:15:24 ~21 min android 📦 apk
✔️ f9a126e #8 2019-05-16 12:17:55 ~23 min windows 📦 exe
✔️ f9a126e #8 2019-05-16 12:18:04 ~23 min ios 📦 ipa
✔️ e10d59e #10 2019-05-17 01:51:28 ~16 min android-e2e 📦 apk
✔️ e10d59e #9 2019-05-17 01:54:08 ~19 min android 📦 apk
✔️ e10d59e #10 2019-05-17 01:54:26 ~19 min linux 📦 App
✔️ e10d59e #9 2019-05-17 01:54:33 ~19 min macos 📦 dmg
✔️ e10d59e #9 2019-05-17 01:55:36 ~20 min windows 📦 exe
✔️ e10d59e #9 2019-05-17 01:59:21 ~24 min ios 📦 ipa

@yenda yenda force-pushed the feature/token-transaction-signals branch from f87783c to 344b027 Compare May 10, 2019 17:31
@yenda yenda self-assigned this May 10, 2019
@yenda yenda force-pushed the feature/token-transaction-signals branch 2 times, most recently from b2431aa to f63bf24 Compare May 10, 2019 17:45
@yenda yenda force-pushed the feature/token-transaction-signals branch 2 times, most recently from 75eb403 to 72a3c1c Compare May 15, 2019 20:29
@yenda yenda force-pushed the feature/token-transaction-signals branch from 72a3c1c to 111bc0e Compare May 15, 2019 22:10
@yenda
Copy link
Contributor Author

yenda commented May 16, 2019

@jeluard @flexsurfer @siphiuel please review this PR so it can go to testing

flexsurfer
flexsurfer approved these changes May 16, 2019
View reviewed changes
src/status_im/accounts/logout/core.cljs Show resolved Hide resolved
src/status_im/ethereum/subscriptions.cljs Outdated Show resolved Hide resolved
src/status_im/ethereum/subscriptions.cljs Show resolved Hide resolved
src/status_im/ethereum/subscriptions.cljs
(fn [response]
(if (string/blank? response)
(log/warn :web3-response-error)
(callback (-> (.parse js/JSON response)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json->clj

@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 49
Failed tests: 0
Passed tests: 49

Passed tests (49)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_swipe_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_swipe_to_delete_1_1_chat
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_offline_status
Device sessions

42. test_open_google_com_via_open_dapp
Device sessions

43. test_unread_messages_counter_public_chat
Device sessions

44. test_sign_message_from_daap
Device sessions

45. test_user_can_remove_profile_picture
Device sessions

46. test_share_contact_code_and_wallet_address
Device sessions

47. test_request_eth_in_wallet
Device sessions

48. test_refresh_button_browsing_app_webview
Device sessions

49. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda yenda force-pushed the feature/token-transaction-signals branch from 111bc0e to f9a126e Compare May 16, 2019 11:54
@yenda yenda requested review from antdanchenko, churik, jakubgs and a team as code owners May 16, 2019 11:54
@yenda
Copy link
Contributor Author

yenda commented May 16, 2019

@flexsurfer @churik I propose to merge these wallet related PR into a meta wallet PR so that they are code reviewed in small iterations and can be QA tested all at once since they are all related to the transaction history

[feature] use subscriptions for tokens
e10d59e 
- removes fetching of last 100000 blocks of token transfers from
the wallet pull loop
- fetches the last 100000 blocks of token transfers at startup
- replaces pulling by subscriptions to ethlogs for token transfers
@yenda yenda force-pushed the feature/token-transaction-signals branch from f9a126e to e10d59e Compare May 17, 2019 01:34
@churik churik self-assigned this May 17, 2019
@churik
Copy link
Member

churik commented May 17, 2019 •
edited
Loading

@yenda so it is not meta PR yet, yes?

@yenda
Copy link
Contributor Author

yenda commented May 17, 2019

@churik no it is not because #8221 is still in review, are you going to test this one now?

@churik
Copy link
Member

churik commented May 17, 2019

I just picked it up from To Test - not sure how we can mark it.
OK. I'll wait for #8221

@yenda
Copy link
Contributor Author

yenda commented May 17, 2019 •
edited
Loading

@churik what you can do is test #8221 directly (it is based on this one), there will probably be only be minor request for changes in the code review and if you find some bugs I can fix them early

@yenda yenda mentioned this pull request May 17, 2019
Merged
@yenda yenda closed this May 17, 2019
@jakubgs jakubgs deleted the feature/token-transaction-signals branch May 12, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitvly vitvly vitvly approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@jeluard jeluard Awaiting requested review from jeluard

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@churik churik Awaiting requested review from churik

@jakubgs jakubgs Awaiting requested review from jakubgs jakubgs is a code owner

Assignees

@churik churik

Labels
performance
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yenda @status-im-auto @statustestbot @churik @vitvly @flexsurfer