Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use status-go subscriptions for wallet #8151

Closed
yenda opened this issue May 8, 2019 · 1 comment · Fixed by #8228
Closed

Use status-go subscriptions for wallet #8151

yenda opened this issue May 8, 2019 · 1 comment · Fixed by #8228
Labels
feature feature requests

Comments

@yenda
Copy link
Contributor

yenda commented May 8, 2019

Problem

As described in https://discuss.status.im/t/proposal-fix-the-transactions-list/1190 the current wallet implementation relies on a loop that pull transaction data from a third party service to fetch the transaction list.

This causes: dependence to a third party service, delays and performance issues.

An overview of the background required to understand the problem.
A problem description.

Implementation

As requested in https://discuss.status.im/t/performances-before-moving-communication-protocol-to-status-go/1199 status-go now exposes an api to subscribe to eth_newFilter, eth_newBlockFilter signals.

The documentation is available here:
https://github.com/status-im/status-go/blob/e541f00e5845f45f471e8c1d39740c8b3a61d6c1/services/subscriptions/README.md

Acceptance Criteria

The current loop is replaced by these subscription and signals.
Status no longer relies on etherscan for fetching the transaction list

@yenda
Copy link
Contributor Author

yenda commented May 15, 2019

Considering the difficulties described here: https://discuss.status.im/t/wallet-improvement-log/1221/2 I propose to amend the Acceptance Criteria on this issue on word it Status no longer relies on etherscan for fetching new transactions while user is logged in. Historical transactions are still fetched by etherscan

#8221 will then close this issue and also fix the token transfer list limitation of 15 days by replacing the current implementation by a call to etherscan token transfer list API.

The next step is to persist transactions #8152
The next step through bounties will be to make etherscan optional to get the transaction and token transfers list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants