Refactor/call params #8233
Closed
Refactor/call params #8233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenda
requested review from
antdanchenko,
churik,
jakubgs and
a team
as code owners
Pull Request Checklist
|
yenda
force-pushed
the
refactor/call-params
branch
from
eb7dbee
to
0f08129
Compare
yenda
force-pushed
the
refactor/call-params
branch
from
0f08129
to
d524f26
Compare
Jenkins BuildsClick to see older builds (17)
|
yenda
force-pushed
the
refactor/call-params
branch
from
d524f26
to
658ef4d
Compare
flexsurfer
approved these changes
May 20, 2019
yenda
force-pushed
the
refactor/call-params
branch
2 times, most recently
from
d8ce0a4
to
7f09650
Compare
yenda
force-pushed
the
refactor/call-params
branch
3 times, most recently
from
b8869a3
to
2482706
Compare
jeluard
approved these changes
May 20, 2019
|
@yenda all builds are failed |
- use `json-rpc/eth-call` and `json-rpc/eth-transaction-call` everywhere - move all conversions to abi-spec
yenda
force-pushed
the
refactor/call-params
branch
from
2482706
to
a56b811
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json-rpc/eth-callandwallet/eth-transaction-calleverywhereThe goal of this PR is to unify the way we interact with contracts, so that future improvements can be made and impact all the callees.
json-rpc/eth-callis for read only calls andwallet/eth-transaction-callis for transnational calls.status: ready