[performance] wallet update #8231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenda
requested review from
antdanchenko,
churik,
jakubgs and
a team
as code owners
Pull Request Checklist
|
yenda
changed the base branch from
meta/wallet-transaction-history
to
refactor/transaction-history
Jenkins BuildsClick to see older builds (18)
|
|
@hesterbruikman could you check out this PR it should improve your wallet experience problems |
yenda
force-pushed
the
refactor/transaction-history
branch
from
a179bdc
to
a256b3a
Compare
yenda
force-pushed
the
refactor/transaction-history
branch
from
a256b3a
to
531223e
Compare
yenda
force-pushed
the
refactor/transaction-history
branch
from
531223e
to
e5bbc7b
Compare
flexsurfer
approved these changes
May 20, 2019
| :rinkeby #{:MOKSHA :KDO} | ||
| :xdai #{} | ||
| :poa #{}}}}) | ||
| :wallet {:visible-tokens {}}}) |
There was a problem hiding this comment.
@flexsurfer I don't understand why we used to force these default tokens on the user, when visible-tokens is empty the wallet autoconfigures and adds the tokens for which the user has a balance.
dmitryn
approved these changes
May 20, 2019
There was a problem hiding this comment.
What's the reason to have re-frame events prepended with :TODO.remove like :TODO.remove/update-estimated-gas and TODO.remove/update-wallet?
Not sure is it used somewhere or not.
UPD: nevermind, i see it's being removed in another PR https://github.com/status-im/status-react/pull/8232/files
|
@dmitryn it is used in some places that are doing things wrong, but that I don't want to touch yet as the scope of these PRs is already big enough. It's to make sure it is obvious that this is not the way to do things |
yenda
force-pushed
the
refactor/transaction-history
branch
from
e5bbc7b
to
a62440e
Compare
`wallet-autoconfig-token` is a very expensive call on mainnet because it checks the balance of every known token. it is called: - when wallet is refreshed by pulling - when user goes on any wallet screen this PR changes that by: - calling it only when the wallet is initialized and there is no visible-token configuration it only calls update-wallet when a new transaction arrives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
a few files are moved around because of circular dependencies, this continues migration of wallet and ethereum code into their own module (previous in
ui.screens.walletandutils.ethereumsrespectively)wallet-autoconfig-tokenis a very expensive call on mainnetbecause it checks the balance of every known token.
it is called:
this PR changes that by:
visible-token configuration
it only calls update-wallet when a new transaction arrives
Testing
I made the following experiment on Android:
satoshi document engage inflict goddess auction rule unfair bid next buddy shydevelop: 2.9mb
PR: 1.9 mb
The difference will be even bigger once persistence is added, the difference is already nice considering the PR pulls both transaction and token transfer history, and does it again everytime it misses a block. With transaction history this number will be very low.
status: ready