Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/transaction history #8230

Closed
wants to merge 1 commit into from
Closed

Refactor/transaction history #8230

wants to merge 1 commit into from

Conversation

yenda
Copy link
Contributor

@yenda yenda commented May 18, 2019 •
edited by 0xc1c4da
Loading

Remove computations from views
Optimize computations in subs
Fix missing amount and label for unknown ERC20 tokens in transfer history

  • clean up transaction history and transaction filters subscriptions
  • move ui.screens.wallet.transactions.events to events
  • move ui.screens.wallet.db to db

Testing notes

To be tested in #8228

status: ready

@yenda yenda added the wallet label May 18, 2019
@yenda yenda requested review from vitvly and flexsurfer May 18, 2019 10:11
@yenda yenda requested review from antdanchenko, churik, jakubgs and a team as code owners May 18, 2019 10:11
@yenda yenda self-assigned this May 18, 2019
@status-github-bot
Copy link

status-github-bot bot commented May 18, 2019 •
edited by yenda
Loading

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@yenda yenda changed the base branch from develop to meta/wallet-transaction-history May 18, 2019 10:15
@status-im-auto
Copy link
Member

status-im-auto commented May 18, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (24)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ 758fe65 #2 2019-05-18 10:19:24 ~4 min linux 📄 log
❌ 758fe65 #2 2019-05-18 10:19:27 ~4 min ios 📄 log
❌ 758fe65 #2 2019-05-18 10:19:52 ~4 min macos 📄 log
❌ 758fe65 #2 2019-05-18 10:20:30 ~5 min windows 📄 log
❌ 758fe65 #2 2019-05-18 10:22:45 ~7 min android-e2e 📄 log
❌ 758fe65 #2 2019-05-18 10:22:56 ~7 min android 📄 log
✔️ a179bdc #3 2019-05-18 12:56:15 ~17 min linux 📦 App
✔️ a179bdc #3 2019-05-18 12:59:17 ~20 min windows 📦 exe
✔️ a179bdc #3 2019-05-18 12:59:30 ~20 min macos 📦 dmg
✔️ a179bdc #3 2019-05-18 13:02:28 ~23 min ios 📦 ipa
✔️ a179bdc #3 2019-05-18 13:03:06 ~23 min android-e2e 📦 apk
✔️ a179bdc #3 2019-05-18 13:03:34 ~24 min android 📦 apk
❌ a256b3a #4 2019-05-18 16:15:41 ~5 min ios 📄 log
❌ a256b3a #4 2019-05-18 16:16:21 ~6 min macos 📄 log
❌ a256b3a #4 2019-05-18 16:16:21 ~6 min linux 📄 log
❌ a256b3a #4 2019-05-18 16:18:07 ~7 min windows 📄 log
❌ a256b3a #4 2019-05-18 16:22:31 ~12 min android-e2e 📄 log
❌ a256b3a #4 2019-05-18 16:23:51 ~13 min android 📄 log
✔️ 531223e #5 2019-05-18 18:39:52 ~15 min linux 📦 App
✔️ 531223e #5 2019-05-18 18:41:36 ~17 min macos 📦 dmg
✔️ 531223e #5 2019-05-18 18:44:25 ~20 min windows 📦 exe
✔️ 531223e #5 2019-05-18 18:47:38 ~23 min ios 📦 ipa
✔️ 531223e #5 2019-05-18 18:47:54 ~24 min android 📦 apk
✔️ 531223e #5 2019-05-18 18:48:14 ~24 min android-e2e 📦 apk
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ e5bbc7b #6 2019-05-20 13:06:12 ~26 min macos 📦 dmg
✔️ e5bbc7b #6 2019-05-20 13:09:54 ~30 min ios 📦 ipa
✔️ e5bbc7b #6 2019-05-20 13:24:02 ~44 min android-e2e 📦 apk
✔️ e5bbc7b #6 2019-05-20 13:27:23 ~47 min windows 📦 exe
✔️ e5bbc7b #6 2019-05-20 13:28:27 ~48 min android 📦 apk
✔️ e5bbc7b #6 2019-05-20 13:29:38 ~49 min linux 📦 App
✔️ a62440e #7 2019-05-20 15:26:20 ~18 min android 📦 apk
✔️ a62440e #7 2019-05-20 15:26:55 ~19 min macos 📦 dmg
✔️ a62440e #7 2019-05-20 15:27:33 ~19 min android-e2e 📦 apk
✔️ a62440e #7 2019-05-20 15:35:11 ~27 min ios 📦 ipa

@yenda yenda force-pushed the refactor/transaction-history branch 3 times, most recently from a256b3a to 531223e Compare May 18, 2019 18:23
@yenda yenda force-pushed the meta/wallet-transaction-history branch from c10b790 to 0bb2b84 Compare May 20, 2019 12:35
@yenda yenda force-pushed the refactor/transaction-history branch from 531223e to e5bbc7b Compare May 20, 2019 12:39
@yenda
Copy link
Contributor Author

yenda commented May 20, 2019

@dmitryn @jeluard please review

@yenda yenda requested review from jeluard and dmitryn May 20, 2019 13:27
@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand
1. test_offline_status

Device 1: Type 'qwerty' to PasswordInput
Device 1: Tap on SignInButton

Device 1: 'PlusButton' is not found on the screen, also Unexpected Alert is shown: 'TypeError: Network request failed'

Device sessions

Passed tests (48)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_swipe_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_swipe_to_delete_1_1_chat
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_stt_from_wallet
Device sessions

34. test_send_eth_in_1_1_chat
Device sessions

35. test_login_with_new_account
Device sessions

36. test_send_eth_from_wallet_to_contact
Device sessions

37. test_add_contact_from_public_chat
Device sessions

38. test_send_two_transactions_one_after_another_in_dapp
Device sessions

39. test_password_in_logcat_creating_account
Device sessions

40. test_backup_recovery_phrase
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

48. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@yenda yenda force-pushed the meta/wallet-transaction-history branch from 0bb2b84 to 60caa4c Compare May 20, 2019 15:07
@yenda yenda force-pushed the refactor/transaction-history branch from e5bbc7b to a62440e Compare May 20, 2019 15:07
@yenda yenda mentioned this pull request May 20, 2019
Merged
@yenda yenda closed this May 20, 2019
@jakubgs jakubgs deleted the refactor/transaction-history branch May 12, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryn dmitryn dmitryn approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@vitvly vitvly Awaiting requested review from vitvly

@antdanchenko antdanchenko Awaiting requested review from antdanchenko

@churik churik Awaiting requested review from churik

@jakubgs jakubgs Awaiting requested review from jakubgs

@jeluard jeluard Awaiting requested review from jeluard

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yenda @status-im-auto @statustestbot @dmitryn @flexsurfer