Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter for security updates only in Dependabot #9207

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

pedropombeiro
Copy link
Contributor

@pedropombeiro pedropombeiro commented Oct 14, 2019

Summary

This PR configures Dependabot to only create package update PRs for security updates.

status: ready

@pedropombeiro pedropombeiro requested a review from a team as a code owner October 14, 2019 16:46
@pedropombeiro pedropombeiro self-assigned this Oct 14, 2019
@auto-assign auto-assign bot removed the request for review from a team October 14, 2019 16:46
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@pedropombeiro pedropombeiro force-pushed the dependabot-security-only-updates branch from 9816ec2 to cb68889 Compare October 14, 2019 16:49
@status-im-auto
Copy link
Member

status-im-auto commented Oct 14, 2019

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 9816ec2 #1 2019-10-14 16:58:09 ~11 min ios 📦ipa 📲
✔️ 9816ec2 #1 2019-10-14 17:00:24 ~13 min macos 📦dmg
cb68889 #2 2019-10-14 17:02:16 ~13 min android 📄log
✔️ cb68889 #2 2019-10-14 17:02:20 ~13 min android-e2e 📦apk 📲
✔️ cb68889 #2 2019-10-14 17:03:23 ~14 min linux 📦App
✔️ cb68889 #2 2019-10-14 17:04:06 ~14 min windows 📦exe
✔️ cb68889 #2 2019-10-14 17:07:14 ~17 min ios 📦ipa 📲
✔️ cb68889 #2 2019-10-14 17:13:24 ~24 min macos 📦dmg
✔️ cb68889 #3 2019-10-15 15:07:10 ~16 min android 📦apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
f5f52c2 #4 2019-10-16 11:52:45 ~25 sec android 📄log
f5f52c2 #3 2019-10-16 11:52:46 ~23 sec windows 📄log
f5f52c2 #3 2019-10-16 11:52:46 ~25 sec linux 📄log
✔️ f5f52c2 #3 2019-10-16 12:03:55 ~11 min android-e2e 📦apk 📲
f5f52c2 #3 2019-10-17 07:42:07 ~19 hr ios 📄log
f5f52c2 #3 2019-10-17 07:42:31 ~19 hr macos 📄log
✔️ 0af3f22 #5 2019-10-17 08:40:16 ~11 min android 📦apk 📲
✔️ 0af3f22 #4 2019-10-17 08:40:32 ~12 min ios 📦ipa 📲
✔️ 0af3f22 #4 2019-10-17 08:41:41 ~13 min linux 📦App
✔️ 0af3f22 #4 2019-10-17 08:42:32 ~14 min macos 📦dmg
✔️ 0af3f22 #4 2019-10-17 08:42:59 ~14 min windows 📦exe
✔️ 0af3f22 #4 2019-10-17 08:44:51 ~16 min android-e2e 📦apk 📲

@jakubgs
Copy link
Member

jakubgs commented Oct 15, 2019

I keep seeing this purely random test failures in various PRs:

;; ======================================================================
;; Testing with Node:

Error: Cannot find module 'fbjs/lib/emptyObject'
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
    at Module._load (internal/modules/cjs/loader.js:507:25)
    at Function.hookedLoader [as _load] (/home/jenkins/workspace/status-react_prs_android_PR-9207/target/test/test.js:14:10)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at require (internal/modules/cjs/helpers.js:22:18)
    at Object.<anonymous> (/home/jenkins/workspace/status-react_prs_android_PR-9207/node_modules/create-react-class/factory.js:13:19)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
Error encountered performing task 'doo' with profile(s): 'test'
Subprocess failed

Some other examples:

I really don't get what it's supposed to mean. @churik @Serhy do you have any idea?

@Serhy
Copy link
Contributor

Serhy commented Oct 15, 2019

Not clear for me even which unittest exactly fails there.
Maybe @flexsurfer you have an idea?

@flexsurfer
Copy link
Member

@yenda ?

@pedropombeiro pedropombeiro force-pushed the dependabot-security-only-updates branch 2 times, most recently from f5f52c2 to 0af3f22 Compare October 17, 2019 08:28
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs force-pushed the dependabot-security-only-updates branch from 0af3f22 to d317d8a Compare October 17, 2019 09:05
@jakubgs jakubgs merged commit d317d8a into develop Oct 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot-security-only-updates branch October 17, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants