Upgrade xcode version to 11.1 #9172
Conversation
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (36)
|
pedropombeiro
force-pushed
the
upgrade-xcode-version
branch
from
912ce4d to
bc6b374
Compare
jakubgs
force-pushed
the
upgrade-xcode-version
branch
from
bc6b374 to
8689063
Compare
|
The android tests seem broken: [nix-shell:~/workspace/status-react_prs_android_PR-9172]$ lein test-cljs
;; ======================================================================
;; Testing with Node:
internal/modules/cjs/loader.js:583
throw err;
^
Error: Cannot find module 'react'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Module._load (internal/modules/cjs/loader.js:507:25)
at Function.hookedLoader [as _load] (/home/jenkins/workspace/status-react_prs_android_PR-9172/target/test/test.js:14:10)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:22:18)
at /home/jenkins/workspace/status-react_prs_android_PR-9172/target/test/reagent/impl/util.js:11:139
at Object.<anonymous> (/home/jenkins/workspace/status-react_prs_android_PR-9172/target/test/reagent/impl/util.js:17:3)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
Error encountered performing task 'doo' with profile(s): 'test'
Subprocess failedNot sure how XCode change could have caused that, must be something unrelated. |
|
I tested exactly the same thing on my local machine and it works fine: |
jakubgs
force-pushed
the
upgrade-xcode-version
branch
from
8689063 to
6d1653a
Compare
|
Okay, the only remaining failing build is MacOS one: Seems like XCode upgrade changed something about the signing. |
jakubgs
force-pushed
the
upgrade-xcode-version
branch
from
6d1653a to
628acf1
Compare
|
The MacOS signing issue seems to be clearly related to XCode upgrade based on this issue:
And this link seems to indicate it's a matter of adjusting options when running
|
|
This thread on Apple developer portal might shed some more light on the issue:
And:
It appears something called |
|
This article seems to explain it:
The requirements are as follows:
This looks like a decent amount of work. |
|
I tested the two types of assessments that are done with But the Which is weird, because it's the |
|
Right, so it appears the DMG check fails, as I expected: |
|
The <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>assessment:authority</key>
<dict>
<key>assessment:authority:flags</key>
<integer>0</integer>
<key>assessment:authority:row</key>
<integer>15</integer>
<key>assessment:authority:source</key>
<string>Unnotarized Developer ID</string>
</dict>
<key>assessment:remote</key>
<true/>
<key>assessment:verdict</key>
<false/>
</dict>
</plist> |
|
According to Apple article:
My first idea was to run the |
|
Based on my comment above which lists how many stars have to align to gain this mysterious "Notarization" status I think it would be prudent to just disable the Considering that the MacOS app doesn't even start, it just crashes, if you just ignore the security warning, then fixing the signing verification seems pointless. I'm going to push a change that just disables this check temporarily. |
jakubgs
force-pushed
the
upgrade-xcode-version
branch
from
2469ccb to
8488660
Compare
|
I've submitted a separate issue about this "notarization": #9212 Would you be fine with this PR in order to tackle the MacOS issues separately? I don't want to block the XCode 11.1 upgrade (already 2/3 CI hosts are upgraded) just due to this, especially since people report that MacOS build crashes anyway. |
I'm OK with that since Desktop is not in V1 list. Plus, it seems this behavior of #9212 I had with previous builds. |
Also: - nix: Disable symlink store check - Add comments to dependabot config file Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
upgrade-xcode-version
branch
from
8488660 to
8e90103
Compare
status: ready