Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add info about MacOS Catalina workaround #9218

Merged
merged 1 commit into from
Oct 16, 2019
Merged

add info about MacOS Catalina workaround #9218

merged 1 commit into from
Oct 16, 2019

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Oct 15, 2019

Forgot to add it in #9172.

@jakubgs jakubgs added the docs label Oct 15, 2019
@jakubgs jakubgs self-assigned this Oct 15, 2019
@ghost
Copy link

ghost commented Oct 15, 2019

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Oct 15, 2019 •
edited
Loading

Jenkins Builds

Click to see older builds (6)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 0954b61 #1 2019-10-15 17:13:12 ~10 min ios 📦ipa 📲
❌ 0954b61 #1 2019-10-15 17:15:40 ~12 min android 📄log
❌ 0954b61 #1 2019-10-15 17:15:42 ~12 min macos 📄log
✔️ 0954b61 #1 2019-10-15 17:15:48 ~12 min android-e2e 📦apk 📲
✔️ 0954b61 #1 2019-10-15 17:17:10 ~14 min linux 📦App
✔️ 0954b61 #1 2019-10-15 17:17:57 ~15 min windows 📦exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d2ef195 #2 2019-10-15 21:20:09 ~10 min ios 📦ipa 📲
✔️ d2ef195 #2 2019-10-15 21:22:57 ~13 min android 📦apk 📲
✔️ d2ef195 #2 2019-10-15 21:22:57 ~13 min android-e2e 📦apk 📲
✔️ d2ef195 #2 2019-10-15 21:23:29 ~13 min linux 📦App
✔️ d2ef195 #2 2019-10-15 21:23:42 ~13 min windows 📦exe
❌ d2ef195 #2 2019-10-15 21:24:18 ~14 min macos 📄log
✔️ 76c00ba #3 2019-10-15 22:09:33 ~10 min ios 📦ipa 📲
❌ 76c00ba #3 2019-10-15 22:09:45 ~10 min android-e2e 📄log
❌ 76c00ba #3 2019-10-15 22:09:51 ~10 min android 📄log
✔️ 76c00ba #3 2019-10-15 22:12:29 ~13 min linux 📦App
✔️ 76c00ba #3 2019-10-15 22:12:46 ~13 min windows 📦exe
❌ 76c00ba #3 2019-10-15 22:12:55 ~13 min macos 📄log

pedropombeiro
pedropombeiro approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@pedropombeiro pedropombeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something about export NIX_IGNORE_SYMLINK_STORE=1?

nix/README.md Outdated Show resolved Hide resolved
nix/README.md Outdated Show resolved Hide resolved
@jakubgs
add info about MacOS Catalina workaround
95e48a4 
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 95e48a4 into develop Oct 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-nix-readme branch October 16, 2019 07:12
@weekly-digest weekly-digest bot mentioned this pull request Oct 20, 2019
Closed
@jakubgs jakubgs mentioned this pull request Feb 23, 2024
Merged
7 tasks
jakubgs added a commit that referenced this pull request Feb 23, 2024
@jakubgs
ci: drop NIX_IGNORE_SYMLINK_STORE from Makefile and CI
ed5193e 
This is a fix applied when upgrading to macOS Catalina in 2019:

#9218

I do not believe it is necessary any longer.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs mentioned this pull request Feb 23, 2024
Merged
jakubgs added a commit that referenced this pull request Feb 23, 2024
@jakubgs
ci: drop NIX_IGNORE_SYMLINK_STORE from Makefile and CI
708fa07 
This is a fix applied when upgrading to macOS Catalina in 2019:

#9218

I do not believe it is necessary any longer.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs added a commit that referenced this pull request Feb 23, 2024
@jakubgs
ci: drop NIX_IGNORE_SYMLINK_STORE from Makefile and CI
13f8702 
This is a fix applied when upgrading to macOS Catalina in 2019:

#9218

I do not believe it is necessary any longer.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
ibrkhalil pushed a commit that referenced this pull request Feb 25, 2024
@jakubgs @ibrkhalil
ci: drop NIX_IGNORE_SYMLINK_STORE from Makefile and CI
c125fa3 
This is a fix applied when upgrading to macOS Catalina in 2019:

#9218

I do not believe it is necessary any longer.

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedropombeiro pedropombeiro pedropombeiro approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@andremedeiros andremedeiros Awaiting requested review from andremedeiros

@cammellos cammellos Awaiting requested review from cammellos

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
docs
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakubgs @status-im-auto @pedropombeiro @flexsurfer