Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add @stdlib/array/base/mskfilter-map #1322

Closed
3 tasks done
kgryte opened this issue Feb 21, 2024 · 7 comments · Fixed by #1705
Closed
3 tasks done

[RFC]: add @stdlib/array/base/mskfilter-map #1322

kgryte opened this issue Feb 21, 2024 · 7 comments · Fixed by #1705
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 21, 2024 •
edited
Loading

Description

This RFC proposes adding the package @stdlib/array/base/mskfilter-map.

The package should be structured similarly to @stdlib/array/base/mskfilter.

The package should expose an API having the same signature as mskfilter, with the addition of clbk and thisArg arguments.

function mskfilterMap( x, mask, clbk[, thisArg ] ) {...}

The callback function should map each selected value specified by mask to the output value.

In short, this package combines mskfilter and map into a single API call.

Package: @stdlib/array/base/mskfilter-map
Alias: mskfilterMap

Related Issues

Related issues #1321 .

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 21, 2024
@kgryte kgryte mentioned this issue Feb 21, 2024
Closed
3 tasks
@kgryte kgryte changed the title [RFC]: add @stdlib/array/base/mskfilter-by [RFC]: add @stdlib/array/base/mskfilter-map Feb 21, 2024
@kanhaiya04
Copy link

@kgryte I want to work on this.

@kgryte
Copy link
Member Author

kgryte commented Feb 22, 2024

Thank you for volunteering to work on this @kanhaiya04. Please feel free to submit a PR implementing this feature.

@kgryte kgryte added priority: Low Low priority concern or feature request. Utilities Issue or pull request concerning general utilities. Accepted RFC feature request which has been accepted. JavaScript Issue involves or relates to JavaScript. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. labels Feb 23, 2024
@Rejoan-Sardar

This comment was marked as outdated.

Sign in to view
@kanhaiya04

This comment was marked as outdated.

Sign in to view
@kgryte

This comment was marked as outdated.

Sign in to view
@kanhaiya04 kanhaiya04 removed their assignment Feb 27, 2024
@AuenKr
Copy link
Contributor

AuenKr commented Feb 28, 2024

Can I work on this issue, as this issue is not assign to anyone currently?

@kgryte
Copy link
Member Author

kgryte commented Feb 28, 2024

@AuenKr Yes, go for it. Thanks!

@AuenKr AuenKr mentioned this issue Mar 5, 2024
Merged
1 task
@AuenKr AuenKr mentioned this issue Mar 13, 2024
Closed
3 tasks
@AuenKr AuenKr removed their assignment May 8, 2024
Planeshifter added a commit that referenced this issue May 18, 2024
@AuenKr @kgryte @Planeshifter
feat: add array/base/mskfilter-map
23e158b 
PR-URL: #1705 
Closes: #1322 

---------

Signed-off-by: Golden <103646877+AuenKr@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add array/base/mskfilter-map AuenKr/stdlib
4 participants
@kgryte @kanhaiya04 @AuenKr @Rejoan-Sardar