Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add array/base/mskfilter-map #1705

Merged
merged 19 commits into from
May 18, 2024
Merged

feat: add array/base/mskfilter-map #1705

merged 19 commits into from
May 18, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 5, 2024

Resolves #1322 .

Description

What is the purpose of this pull request?

This pull request:

  • Adds @stdlib/array/base/mskfilter-map.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 5, 2024

@Planeshifter, can u review this PR?

@Planeshifter Planeshifter self-requested a review March 5, 2024 16:41
@Planeshifter
Copy link
Member

@AuenKr Will do today!

@AuenKr
Copy link
Contributor Author

AuenKr commented Mar 7, 2024

@Planeshifter, waiting for review

@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. JavaScript Issue involves or relates to JavaScript. labels Mar 7, 2024
@kgryte kgryte changed the title feat: add array/base/mskfilter-map feat: add array/base/mskfilter-map Mar 7, 2024
kgryte
kgryte requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AuenKr Thanks for working on this. Left some additional comments.

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 14, 2024
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
@AuenKr AuenKr marked this pull request as draft April 13, 2024 13:46
Planeshifter and others added 2 commits May 17, 2024 21:21
@Planeshifter @kgryte
Apply suggestions from code review
1e00b97 
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
chore: apply suggestions from code review
c2aeb93
@Planeshifter Planeshifter marked this pull request as ready for review May 18, 2024 01:46
Planeshifter
Planeshifter approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AuenKr for this PR! I was so free to finish addressing the remaining feedback and giving the code one more review. Will merge once CI has cleared.

@Planeshifter Planeshifter merged commit 23e158b into stdlib-js:develop May 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. Needs Changes Pull request which needs changes before being merged. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add @stdlib/array/base/mskfilter-map
3 participants
@AuenKr @Planeshifter @kgryte