Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/scusumpw to follow current project conventions #1520

Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #1929
Closed
3 tasks done

[RFC]: refactor blas/ext/base/scusumpw to follow current project conventions #1520

Planeshifter opened this issue Mar 3, 2024 · 2 comments · Fixed by #1929
Assignees
@rxbryan
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/scusumpw to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@rxbryan
Copy link
Contributor

rxbryan commented Mar 15, 2024

Hi @Planeshifter I would love to work on this Issue

@Planeshifter
Copy link
Member Author

@rxbryan just did. Looking forward to your contribution, thanks for taking this on!

rxbryan added a commit to rxbryan/stdlib that referenced this issue Mar 17, 2024
@rxbryan
refactor: update blas/ext/base/scusumpw
3683d51 
updates blas/ext/base/scusumpw to follow current project conventions

Fixes: stdlib-js#1520
@rxbryan rxbryan mentioned this issue Mar 17, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rxbryan rxbryan

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/scusumpw to follow current project conventions rxbryan/stdlib
2 participants
@Planeshifter @rxbryan