Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and update existing base BLAS packages according to current project conventions #788

Closed
18 tasks done
kgryte opened this issue Dec 31, 2022 · 6 comments
Closed
18 tasks done
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 31, 2022

BLAS Updates

Refactor and clean-up existing base BLAS packages according to current project conventions.

Existing base BLAS packages need to be updated according to current project conventions before we can continue building out additional BLAS functionality. What follows is a general list of necessary changes, along with a list of packages which should be updated.

An example commit implementing (most of) these changes can be found in d66d80c (saxpy).

Updates

  1. replace nullptr with NULL
  2. remove namespace (and anything else C++) and use static functions
  3. rename file from addon.cpp to addon.c
  4. update include.gypi to reference addon.c file
  5. use argv macros for handling add-on callback arguments
  6. update benchmarks to use utility functions for generating arrays of random numbers, rather than explicit loops
  7. change "destination array" and "returns y" to "output array" and "returns output array" respectively
  8. change "deep equal" to "returns expected value"
  9. remove use of floor
  10. README and repl.txt copy edits
  11. in *.native.js files, use utilities for creating offset views, rather than explicit typed array creation
  12. update manifest.json file to include argv utility dependencies
  13. update manifest.json to use space indentation to match other project JSON files
  14. update manifest.json to include separate build configurations for compiling the addon, the benchmarks, and the examples.

Packages

@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Dec 31, 2022
@Pranavchiku
Copy link
Member

Working on blas/base/sswap.

@Pranavchiku
Copy link
Member

On blas/base/scopy.

@Pranavchiku
Copy link
Member

Refactoring blas/base/sdot.

@Pranavchiku
Copy link
Member

Refactoring blas/base/sdsdot.

@Pranavchiku
Copy link
Member

Refactoring blas/base/snrm2.

kgryte added a commit that referenced this issue Mar 1, 2023
This commit is part of the work discussed in #788 and updates `@stdlib/blas/base/sdot` according to current project conventions, particularly as concerns the native add-on bridge between JavaScript and C.

PR-URL: #798
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Mar 1, 2023
This commit migrates `@stdlib/blas/base/snrm2` to use current project conventions for authoring add-ons, as discussed in #788.

PR-URL: #800
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
kgryte added a commit that referenced this issue Mar 2, 2023
This commit migrates `@stdlib/blas/base/sdsdot` to use current project conventions, as discussed in #788.

PR-URL: #799
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
@kgryte
Copy link
Member Author

kgryte commented Dec 4, 2023

This work has now been completed. Closing...

kgryte added a commit that referenced this issue Mar 4, 2024
…ventions

Closes: #1544
PR-URL: 	#1673
Ref: #788
Ref: #1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
@kgryte kgryte added the Tracking Issue Tracking issue. label Mar 4, 2024
utkrs01 pushed a commit to utkrs01/stdlib that referenced this issue Mar 7, 2024
…ventions

Closes: stdlib-js#1544
PR-URL: 	stdlib-js#1673
Ref: stdlib-js#788
Ref: stdlib-js#1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Lovelin <100030865+lovelindhoni@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Tracking Issue Tracking issue.
Projects
None yet
Development

No branches or pull requests

2 participants