Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/ssumkbn2 to follow current project conventions #1542

Closed
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 7 comments · Fixed by #1873
Closed
3 tasks done

[RFC]: refactor blas/ext/base/ssumkbn2 to follow current project conventions #1542

Planeshifter opened this issue Mar 3, 2024 · 7 comments · Fixed by #1873
Assignees
@vr-varad
Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/ssumkbn2 to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@vr-varad
Copy link
Contributor

vr-varad commented Mar 6, 2024

@Planeshifter @kgryte I would like to work on this issue could u please assign me??

@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Accepted RFC feature request which has been accepted. labels Mar 7, 2024
@kgryte
Copy link
Member

kgryte commented Mar 7, 2024

@vr-varad Are you currently assigned to any other issues?

@vr-varad
Copy link
Contributor

vr-varad commented Mar 7, 2024 •
edited
Loading

Nope. @kgryte

@kgryte
Copy link
Member

kgryte commented Mar 7, 2024

@vr-varad Just assigned you. Feel free to submit a PR with the requested changes. Thanks for working on this!

This was referenced Mar 7, 2024
Closed
Closed
@vr-varad
Copy link
Contributor

vr-varad commented Mar 7, 2024

Hello @Planeshifter and @kgryte, I'd appreciate your review of my pull request (#1749) whenever you have a moment. Thank you!
(sorry for the last time)

@Pranavchiku
Copy link
Member

Reviewed, thanks for your work!

@vr-varad
Copy link
Contributor

@Pranavchiku I have made the changes as suggested.

@vr-varad vr-varad mentioned this issue Mar 13, 2024
Merged
11 tasks
kgryte added a commit that referenced this issue Mar 22, 2024
@vr-varad @kgryte
refactor: update blas/ext/base/ssumkbn2 to follow current project c…
2fafc74 
…onventions

PR-URL: 	#1873
Closes: #1542
Ref: #1152
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vr-varad vr-varad

Labels
Accepted RFC feature request which has been accepted. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. difficulty: 3 Likely to be challenging but manageable. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
4 participants
@Planeshifter @kgryte @Pranavchiku @vr-varad