Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor @stdlib/blas/base/sswap #794

Merged
merged 9 commits into from
Jan 18, 2023
Merged

Refactor @stdlib/blas/base/sswap #794

merged 9 commits into from
Jan 18, 2023

Conversation

Pranavchiku
Copy link
Member

@Pranavchiku Pranavchiku commented Jan 18, 2023 •
edited
Loading

Checklist

  • update readme.md
  • docs
  • src
  • include.gypi
  • manifest.json
  • package.json
  • lib
  • examples
  • benchmark
  • test

@kgryte

@Pranavchiku Pranavchiku mentioned this pull request Jan 18, 2023
Closed
18 tasks
@kgryte kgryte added Native Addons Issue involves or relates to Node.js native add-ons. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). labels Jan 18, 2023
@Pranavchiku Pranavchiku marked this pull request as ready for review January 18, 2023 06:44
@Pranavchiku
Copy link
Member Author

All tests and benchmarks cleared. This PR can have a review.

kgryte
kgryte approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Pranavchiku!

@kgryte kgryte merged commit ae30838 into stdlib-js:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranavchiku @kgryte