Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dnansumkbn2 to follow current project conventions #1992

Merged
merged 6 commits into from
Mar 26, 2024
Merged

refactor: update blas/ext/base/dnansumkbn2 to follow current project conventions #1992

merged 6 commits into from
Mar 26, 2024

Conversation

kumarsuraj212003
Copy link
Contributor

Resolves #1485 .

Description

What is the purpose of this pull request?

This pull request:

update blas/ext/base/dnansumkbn2 to follow current project conventions

Related Issues

#788, #1152

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 22, 2024
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 22, 2024
@Planeshifter Planeshifter self-requested a review March 23, 2024 22:23
@kumarsuraj212003
Update addon.c
312b08c 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update manifest.json
381eac5 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@Planeshifter
Update lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/src/addon.c
b7aa98f 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/blas/ext/base/dnansumkbn2/manifest.json
0a6a47b 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
fix: add dependencies in benchmark and examples configs
533efc7 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

Planeshifter commented Mar 26, 2024 •
edited
Loading

@kumarsuraj212003 Thanks for your PR! There were a few errors in the manifest.json, so please to make sure going forward to test out your changes with the make commands for running C benchmarks, examples, and tests.

Tested everything locally and will merge shortly.

@Planeshifter Planeshifter merged commit 6246c5d into stdlib-js:develop Mar 26, 2024
8 checks passed
@kumarsuraj212003
Copy link
Contributor Author

@Planeshifter Thank you for the suggestion; I will make sure to run tests locally. Your advice is appreciated.

@Planeshifter Planeshifter added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Mar 26, 2024
@kumarsuraj212003 kumarsuraj212003 mentioned this pull request Mar 27, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter left review comments

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnansumkbn2 to follow current project conventions
3 participants
@kumarsuraj212003 @Planeshifter @stdlib-bot