Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dapxsumkbn to follow current project conventions #1906

Merged
merged 22 commits into from
Mar 22, 2024
Merged

refactor: update blas/ext/base/dapxsumkbn to follow current project conventions #1906

merged 22 commits into from
Mar 22, 2024

Conversation

kumarsuraj212003
Copy link
Contributor

Resolves #1466 .

Description

What is the purpose of this pull request?

This pull request: refactor blas/ext/base/dapxsumkbn to follow current project conventions.

Related Issues

Related issues #788, #1152.

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 15, 2024
@kumarsuraj212003 kumarsuraj212003 changed the title refactor: update to follow current project conventions refactor: update blas/ext/base/dapxsumkbn to follow current project conventions Mar 15, 2024
@Pranavchiku
chore: apply suggestions from code review
6b6148e 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku requested changes Mar 16, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested. Thanks for your works!

@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 16, 2024
Pranavchiku
Pranavchiku requested changes Mar 17, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@kumarsuraj212003
Update test.dapxsumkbn.native.js
27a7157 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update test.ndarray.js
4b9ba06 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update test.ndarray.native.js
c31336d 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update test.dapxsumkbn.js
79be673 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update manifest.json
69d96fd 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Merge branch 'stdlib-js:develop' into issue1466
26e7618
@kumarsuraj212003
Update README.md
40956e6 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update README.md
df87ba6 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Copy link
Contributor Author

pinging @Pranavchiku for the review

@kumarsuraj212003
Update index.js
d5c21d9 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update test.dapxsumkbn.js
fde3832 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kumarsuraj212003
Update test.dapxsumkbn.native.js
2984f03 
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@Planeshifter
Apply suggestions from code review
420a23c 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update manifest.json
6f160a2 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
Planeshifter approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Made a few edits, but this should now be ready to be merged. Will do so after CI has passed.

@Planeshifter
Update lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn/test/test.da…
baa9327 
…pxsumkbn.js

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Update lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn/test/test.da…
29f3ede 
…pxsumkbn.native.js

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 7b29fe4 into stdlib-js:develop Mar 22, 2024
8 checks passed
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 22, 2024
kgryte added a commit that referenced this pull request Mar 22, 2024
@kgryte
fix: update build configurations and add missing include
e3bf989 
Ref: #1906
Ref: 7b29fe4
@kumarsuraj212003 kumarsuraj212003 mentioned this pull request Mar 27, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Awaiting requested review from Pranavchiku

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dapxsumkbn to follow current project conventions
5 participants
@kumarsuraj212003 @Planeshifter @Pranavchiku @kgryte @stdlib-bot