-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update blas/ext/base/dapxsumkbn2
to follow current project conventions
#1978
Conversation
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn2/manifest.json
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/ext/base/dapxsumkbn2/manifest.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Left a few comments; mainly the manifest.json
file has to be updated. Please have a look at how we have been updating it in some of the linked PRs in the RFC.
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@Planeshifter thanks for review, I added suggested changes, can you please tell me why my |
@kumarsuraj212003 The |
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kgryte |
Done. You're missing an include and the |
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
@kgryte I think I understood what you wanted me to correct, and I have made the necessary adjustments, including adding the missing include and updating the dependencies in the |
Signed-off-by: Suraj kumar <125961509+kumarsuraj212003@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR into a good shape! LGTM. I will merge it shortly.
Resolves #1467 .
Description
refactor
blas/ext/base/dapxsumkbn2
to follow current project conventionsThis pull request:
Related Issues
#788, #1152
This pull request:
blas/ext/base/dapxsumkbn2
to follow current project conventions #1467Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers