Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/assert/int32-is-odd #1865

Merged
merged 8 commits into from
Mar 14, 2024
Merged

feat: add C implementation for math/base/assert/int32-is-odd #1865

merged 8 commits into from
Mar 14, 2024

Conversation

Rejoan-Sardar
Copy link
Contributor

Resolves #1806 .

Description

What is the purpose of this pull request?

This pull request:

  • add C implementation for math/base/assert/int32-is-odd

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

@stdlib-js/reviewers

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-odd/README.md Outdated

The function accepts the following arguments:

- **x**: `[in] long` input value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **x**: `[in] long` input value.
- **x**: `[in] int32_t` input value.

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-odd/README.md Outdated
- **x**: `[in] long` input value.

```c
bool stdlib_base_int32_is_odd( const long x );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool stdlib_base_int32_is_odd( const long x );
bool stdlib_base_int32_is_odd( const int32_t x );

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-odd/README.md Outdated
#include <stdbool.h>

int main( void ) {
const long x[] = { 5, -5, 3, -3, 0, 0/0 };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const long x[] = { 5, -5, 3, -3, 0, 0/0 };
const int32_t x[] = { 5, -5, 3, -3, 0 };

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-odd/examples/c/example.c Outdated
#include <stdbool.h>

int main( void ) {
const long x[] = { 5, -5, 3, -3, 0, 0/0 };
Copy link
Member

@Pranavchiku Pranavchiku Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const long x[] = { 5, -5, 3, -3, 0, 0/0 };
const int32_t x[] = { 5, -5, 3, -3, 0 };

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
...modules/@stdlib/math/base/assert/int32-is-odd/include/stdlib/math/base/assert/int32_is_odd.h Outdated
/**
* Tests if 32-bit integer is odd.
*/
bool stdlib_base_is_odd( const long x );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool stdlib_base_is_odd( const long x );
bool stdlib_base_int32_is_odd( const int32_t x );

Pranavchiku
Pranavchiku reviewed Mar 13, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/assert/int32-is-odd/src/addon.c Outdated
Comment on lines 62 to 63
long x;
status = napi_get_value_long( env, argv[ 0 ], &x );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
long x;
status = napi_get_value_long( env, argv[ 0 ], &x );
int32_t x;
status = napi_get_value_int32( env, argv[ 0 ], &x );

@Pranavchiku
chore: apply suggestions from code review
7d8a116 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
6a0aaf8 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
4417215 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
9b4880d 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku
chore: apply suggestions from code review
46f1689 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
@Pranavchiku Pranavchiku changed the title feat: add C implementation for math/base/assert/int32-is-odd feat: add C implementation for math/base/assert/int32-is-odd Mar 13, 2024
Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything works. Thanks @Rejoan-Sardar !

Pranavchiku
Pranavchiku approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything works. Thanks @Rejoan-Sardar !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. labels Mar 13, 2024
@Planeshifter
Apply suggestions from code review
966b83b 
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

Thanks @Rejoan-Sardar! Will merge ASAP.

@Planeshifter Planeshifter merged commit d14500f into stdlib-js:develop Mar 14, 2024
7 checks passed
This was referenced Mar 17, 2024
Closed
Closed
@Rejoan-Sardar Rejoan-Sardar mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: feat: add C implementation for @stdlib/math/base/assert/int32-is-odd
3 participants
@Rejoan-Sardar @Planeshifter @Pranavchiku