feat: add lapack/base/dlacpy
#2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pranavchiku
added
the
LAPACK
|
@Pranavchiku Given the recent change in approach for the |
kgryte
added
the
Needs Changes
|
I marked it as draft, I am refactoring implementation. |
|
Applied changes, I think this PR can have a review. |
kgryte
reviewed
Jul 15, 2024
kgryte
reviewed
Jul 15, 2024
Pranavchiku
commented
Jul 28, 2024
Pranavchiku
commented
Jul 28, 2024
lib/node_modules/@stdlib/lapack/base/dlacpy/benchmark/benchmark.ndarray.js
Show resolved
Hide resolved
Pranavchiku
added
Needs Review
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
kgryte
approved these changes
Jul 28, 2024
There was a problem hiding this comment.
LGTM. Thanks for working on this, @Pranavchiku.
Note that I had to make a number of clean-up changes. And also, wrt testing, two things:
- Testing for approximate equality doesn't make sense for this package.
- It isn't enough to test on wide matrices, but not long matrices. We need to test on both to ensure that loop limits work appropriately.
gunjjoshi
pushed a commit
to gunjjoshi/stdlib
that referenced
this pull request
Aug 21, 2024
PR-URL: stdlib-js#2548 Co-authored-by: Athan Reines <kgryte@gmail.com> Reviewed-by: Athan Reines <kgryte@gmail.com> Signed-off-by: Pranav Goswami <goswami.4@iitj.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds JS implementation for
lapack/blas/dlacpyRelated Issues
No.
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers