bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic

[gkbishnoi07]

Description

What is the purpose of this pull request?

This pull request:

• Refactors random number generation in JS benchmarks for stats/base/dists/logistic.
• Replaces randu() with uniform() for cleaner and more consistent code.
• Moves the random number generation outside the benchmarking loops to improve efficiency.

Related Issues

Does this pull request have any related issues?

This pull request:

• Resolves [RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/logistic #4978

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines

[stdlib-bot]

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

1. Please read our contributing guidelines.

2. Update your pull request description to include this checked box:

   - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

• The developer's certificate of origin
• Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

[stdlib-bot]

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/logistic/cdf	$\color{green}209/209$ $\color{green}+100.00\%$	$\color{green}23/23$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}209/209$ $\color{green}+100.00\%$
stats/base/dists/logistic/ctor	$\color{green}488/488$ $\color{green}+100.00\%$	$\color{green}36/36$ $\color{green}+100.00\%$	$\color{green}19/19$ $\color{green}+100.00\%$	$\color{green}488/488$ $\color{green}+100.00\%$
stats/base/dists/logistic/entropy	$\color{green}113/113$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}113/113$ $\color{green}+100.00\%$
stats/base/dists/logistic/kurtosis	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/logistic/logcdf	$\color{green}288/288$ $\color{green}+100.00\%$	$\color{green}29/29$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}288/288$ $\color{green}+100.00\%$
stats/base/dists/logistic/logpdf	$\color{green}241/241$ $\color{green}+100.00\%$	$\color{green}27/27$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}241/241$ $\color{green}+100.00\%$
stats/base/dists/logistic/mean	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/logistic/median	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/logistic/mgf	$\color{red}228/230$ $\color{green}+99.13\%$	$\color{red}17/18$ $\color{green}+94.44\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{red}228/230$ $\color{green}+99.13\%$
stats/base/dists/logistic/mode	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/logistic/pdf	$\color{green}237/237$ $\color{green}+100.00\%$	$\color{green}27/27$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}237/237$ $\color{green}+100.00\%$
stats/base/dists/logistic/quantile	$\color{green}218/218$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{green}218/218$ $\color{green}+100.00\%$
stats/base/dists/logistic/skewness	$\color{green}175/175$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}175/175$ $\color{green}+100.00\%$
stats/base/dists/logistic/stdev	$\color{green}180/180$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}180/180$ $\color{green}+100.00\%$
stats/base/dists/logistic/variance	$\color{green}176/176$ $\color{green}+100.00\%$	$\color{green}9/9$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}176/176$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[gkbishnoi07]

@anandkaranubc ready for review

[anandkaranubc]

@anandkaranubc ready for review

I noticed that you adjusted the spacing in the files, including areas of the code that do not require changes to resolve this issue. That is unnecessary. Reference PRs will help clarify which changes are required.

[gkbishnoi07]

@anandkaranubc ready for review

I noticed that you adjusted the spacing in the files, including areas of the code that do not require changes to resolve this issue. That is unnecessary. Reference PRs will help clarify which changes are required.

Thanks for the feedback! I’ll revert the unnecessary spacing changes and ensure only the required modifications are included. Appreciate the guidance!

[gkbishnoi07]

@anandkaranubc ready for review

[gkbishnoi07]

@anandkaranubc please review this

[gkbishnoi07]

@Planeshifter please review

[anandkaranubc]

@gkbishnoi07, I have left some comments for you to review. Good luck!

[gkbishnoi07]

@gkbishnoi07, I have left some comments for you to review. Good luck!

Thank you! I'll review your comments and get back to you soon.

[gkbishnoi07]

@anandkaranubc Can you please review #5193

[gkbishnoi07]

@anandkaranubc ready for review

[gkbishnoi07]

@anandkaranubc any updates

[gkbishnoi07]

@Planeshifter please review this PR

[gkbishnoi07]

@kgryte can you please review this PRs

[anandkaranubc]

@anandkaranubc ready for review

On it!

[anandkaranubc]

This PR still requires several changes. I have pinpointed the exact areas in my review. You can request another review from me after making those changes. Just ensure that you are 100% certain all the necessary modifications have been made. Good luck!

[gkbishnoi07]

This PR still requires several changes. I have pinpointed the exact areas in my review. You can request another review from me after making those changes. Just ensure that you are 100% certain all the necessary modifications have been made. Good luck!

ok,thanks for review

[gkbishnoi07]

Hi @anandkaranubc, could you please review these PRs when you have time? I'm eager to contribute more to this repo. Thank you!

[gkbishnoi07]

@Planeshifter @kgryte please review this PRs

[anandkaranubc]

Some more changes are needed. The rest looks good!

[gkbishnoi07]

@anandkaranubc please review

[anandkaranubc]

The PR looks ready to be merged. Thanks!

[stdlib-bot]

PR Commit Message

bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic #4978

PR-URL: https://github.com/stdlib-js/stdlib/pull/5139
Closes: https://github.com/stdlib-js/stdlib/issues/4978

Co-authored-by: Gopi Kishan <gkishan1kyt@gmail.com>
Reviewed-by: anandkaranubc <anandkaranubc@users.noreply.github.com>

Please review the above commit message and make any necessary adjustments.

[anandkaranubc]

@gkbishnoi07 Can you also update the title to:

bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic

• Adding backticks around stats/base/dists/logistic
• Removing the issue number from the title

After this, you can wait for a maintainer to merge this PR.

[gkbishnoi07]

@gkbishnoi07 Can you also update the title to:

bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic

• Adding backticks around stats/base/dists/logistic
• Removing the issue number from the title

After this, you can wait for a maintainer to merge this PR.

Yes, sure! Thanks for reviewing my PRs.

[Planeshifter]

Thanks @gkbishnoi07 and @anandkaranubc!