Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic #5139

Merged
merged 11 commits into from
Feb 18, 2025
Merged

bench: refactor random number generation in JS benchmarks for stats/base/dists/logistic #5139

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
741d693
Resolved changes
gkbishnoi07 Feb 9, 2025
f56669b
Resolved changes in cdf/benchmark.js and ctor/benchmark.js
gkbishnoi07 Feb 10, 2025
51da62e
Resolved issue
gkbishnoi07 Feb 10, 2025
fc4f635
Merge branch 'develop' of github.com:gkbishnoi07/stdlib into issue-4978
gkbishnoi07 Feb 13, 2025
b2820b1
applied changes
gkbishnoi07 Feb 13, 2025
0a4ea24
applied changes
gkbishnoi07 Feb 13, 2025
2f9ef6a
resolved eslint issue
gkbishnoi07 Feb 13, 2025
79bf7a4
resolved eslint issue
gkbishnoi07 Feb 13, 2025
a14e04f
all issue resolved
gkbishnoi07 Feb 13, 2025
809f430
Correct the ranges for variables
gkbishnoi07 Feb 16, 2025
f5cbfe3
all issue resolved
gkbishnoi07 Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/logistic/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -33,16 +34,24 @@ var cdf = require( './../lib' );
bench( pkg, function benchmark( b ) {
var mu;
var s;
var len;
var x;
var y;
var i;

len = 100;
mu = new Float64Array( len );
s = new Float64Array( len );
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -100.0, 100.0 );
mu[ i ] = uniform( -50.0, 100.0 );
s[ i ] = uniform( EPS, 20.0);
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*100.0 ) - 100;
mu = ( randu()*100.0 ) - 50.0;
s = ( randu()*20.0 ) + EPS;
y = cdf( x, mu, s );
y = cdf( x[ i % len ], mu[ i % len ], s[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -59,18 +68,23 @@ bench( pkg+':factory', function benchmark( b ) {
var mycdf;
var mu;
var s;
var len;
var x;
var y;
var i;

mu = 10.0;
s = 4.0;
mycdf = cdf.factory( mu, s );
len = 100;
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( 0.0, 50.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*50.0 );
y = mycdf( x );
y = mycdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -81,4 +95,4 @@ bench( pkg+':factory', function benchmark( b ) {
}
b.pass( 'benchmark finished' );
b.end();
});
});
Loading
Loading