Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Allow usage on centralized exchanges #102

Closed
nikhilsaraf opened this issue Feb 6, 2019 · 0 comments · Fixed by #118
Closed

Allow usage on centralized exchanges #102

nikhilsaraf opened this issue Feb 6, 2019 · 0 comments · Fixed by #118
Assignees
@nikhilsaraf
Labels
feature request New feature or request
Milestone
v1.6.0

Comments

@nikhilsaraf
Copy link
Contributor

Desired Behavior

I want to be able to trade on centralized exchanges

Impact

The desired behavior will allow me to manage the liquidity for my token on centralized exchanges via the CCXT integration.

Feature Suggestion

We can achieve the desired behavior by creating an interface shim.
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Feb 6, 2019
@nikhilsaraf nikhilsaraf self-assigned this Feb 6, 2019
@nikhilsaraf nikhilsaraf added this to the v1.5.0 milestone Feb 22, 2019
@nikhilsaraf nikhilsaraf modified the milestones: v1.5.0, v1.6.0 Mar 5, 2019
This was referenced Mar 11, 2019
Closed
Closed
Merged
nikhilsaraf added a commit that referenced this issue Mar 12, 2019
@nikhilsaraf
Enable centralized trading2 (#118), closes #102
505162a 
* 1 - GetAccountBalances API and impls.

* 2 - new interface types in exchange, submittable exchang and Balance

* 3 - typo in ccxtExchange.go

* 4 - merge in changes first attempt

* 5 - remove redundant check of fixedIterations

* 6 - add check for valid submitMode for non-sdex exchange

* 7 - use balance and offers hack methods in trader/trader.go

* 8 - incorporate changes into trade.go and trader.go

* 9 - explicilty disable fill tracking for non-sdex exchanges

* 10 - cursor support to ccxt.go#FetchMyTrades

* 11 - log file name, don't log native by default

* 12 - errorSuffix in batchedExchange log line on submit result

* 13 !! - fix krakenExchange tradeHistory cursor logic

* 14 - sdex tradingOnSdex

* 15 - more %.7f -> %.8f changes

* 16 - wrap error when cannot load open orders for kraken

* 17 - API fixes for MakeIEIF

* 18 - correct name of /health endpoint

* 19 - use 7 for SdexPrecision

* 20 - remove redundant log lines in factory.go

* 21 - add check for ccxt trading needing exactly 1 API key

* 22 - update sample_trader.cfg

* 23 - rename SubmittableExchange to ExchangeShim

* 24 - make FEE config field optional when not trading on SDEX

* 25 - use exchange precision when converting from manageOffer2Order

* 26 - use large precision for intermediate conversion in manageOffer2Order; log orderConstraints

* 27 - include minQuote volume in cost, displayed when logging orderConstraints
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
feature request New feature or request
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Enable centralized trading2 nikhilsaraf/kelp
1 participant
@nikhilsaraf