Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transaction result processing to parse offers correctly. #681

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Aug 26, 2021

This updates stellar-base to be compatible with CAP-38 (v6.0.1), and also updates the offer response processor to be work with the new ClaimAtom changes. Specifically, the seller ID needs to be parsed out differently depending on the type of ClaimAtom encountered.

@Shaptic Shaptic added the amm label Aug 26, 2021
@Shaptic Shaptic self-assigned this Aug 26, 2021
@Shaptic Shaptic changed the title Update the stellar-base library to the latest version. Update transaction result processing to parse offers correctly. Aug 26, 2021
Copy link
Contributor

@marcelosalloum marcelosalloum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 27, 2021

I think the failing tests are transient, so I'm just gonna merge this in.

@Shaptic Shaptic merged commit ede9372 into v9.0.0 Aug 27, 2021
@Shaptic Shaptic deleted the bump-js-base branch August 27, 2021 00:53
Shaptic added a commit that referenced this pull request Sep 2, 2021
* Use stellar-base 6.0.1 from the npm registry.
* Correctly process transaction response for offers based on XDR changes (#681)
* Adds a basic call builder for the `/liquidity_pools` endpoint. (#682)
* Add call builder for liquidity pools, w/ filters by reserve asset
* Update TradesCallBuilder to accept the trade_type filter and support Liquidity Pool trades (#685)
* [CD/CI] Add GitHub Actions to run tests on PRs (#686)
* Support filtering accounts participating in a given LP and update accounts balance response (#688)
* Allow querying a single liquidity pool by its specific ID. (#687)
* Allow querying actions (ops, txs, fx) related to a specific liquidity pool. (#689)
* Add new effect types (#690)
* Refactors call builders to simplify referencing 'neighbor' endpoints (#691)
* Update with CAP-38 operations (#692)
* Simplifies an expression to be more readable (#695)
* Updates the CHANGELOG to be more uniform and specific. (#694)
* Fix how the ?reserves filter works on the /accounts endpoint (#698)
* Update more call builders to use the new helper API. (#699)
* Add integration tests against the real mock API server (#697)
* Prepares the v9.0.0 branch for merging into master (#701)
* Update Horizon API fields to reflect the coming post-AMM API (#702)

Co-authored-by: Marcelo Salloum dos Santos <marcelo@stellar.org>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George Kudrayvtsev <george@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants