Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new effect types #690

Merged
merged 7 commits into from
Aug 31, 2021
Merged

Add new effect types #690

merged 7 commits into from
Aug 31, 2021

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Aug 31, 2021

Add

  • New effect types: DepositLiquidityEffect, WithdrawLiquidityEffect, LiquidityPoolTradeEffect, LiquidityPoolCreatedEffect, LiquidityPoolRemovedEffect and LiquidityPoolRevokedEffect.

Breaking changes

  • Trustline created/updated/revoked effects' asset type can now be liquidity_pool_shares.
  • Trustline sponsorship effects have been updated so the asset becomes optional and is replaced with liquidity_pool_id for liquidity pools.

@marcelosalloum marcelosalloum self-assigned this Aug 31, 2021
@marcelosalloum marcelosalloum mentioned this pull request Aug 31, 2021
14 tasks
@marcelosalloum marcelosalloum marked this pull request as ready for review August 31, 2021 13:10
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one suggestion re: types.

Also, I'm realizing we don't have tests to validate the types on these, well, effects? Worth noting for the future.

src/types/effects.ts Outdated Show resolved Hide resolved
@marcelosalloum marcelosalloum merged commit bc3e502 into v9.0.0 Aug 31, 2021
@marcelosalloum marcelosalloum deleted the cap38/effects branch August 31, 2021 18:48
Shaptic added a commit that referenced this pull request Sep 2, 2021
* Use stellar-base 6.0.1 from the npm registry.
* Correctly process transaction response for offers based on XDR changes (#681)
* Adds a basic call builder for the `/liquidity_pools` endpoint. (#682)
* Add call builder for liquidity pools, w/ filters by reserve asset
* Update TradesCallBuilder to accept the trade_type filter and support Liquidity Pool trades (#685)
* [CD/CI] Add GitHub Actions to run tests on PRs (#686)
* Support filtering accounts participating in a given LP and update accounts balance response (#688)
* Allow querying a single liquidity pool by its specific ID. (#687)
* Allow querying actions (ops, txs, fx) related to a specific liquidity pool. (#689)
* Add new effect types (#690)
* Refactors call builders to simplify referencing 'neighbor' endpoints (#691)
* Update with CAP-38 operations (#692)
* Simplifies an expression to be more readable (#695)
* Updates the CHANGELOG to be more uniform and specific. (#694)
* Fix how the ?reserves filter works on the /accounts endpoint (#698)
* Update more call builders to use the new helper API. (#699)
* Add integration tests against the real mock API server (#697)
* Prepares the v9.0.0 branch for merging into master (#701)
* Update Horizon API fields to reflect the coming post-AMM API (#702)

Co-authored-by: Marcelo Salloum dos Santos <marcelo@stellar.org>
Co-authored-by: George <Shaptic@users.noreply.github.com>
Co-authored-by: George Kudrayvtsev <george@stellar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants