-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoothie Proguard config breaks Firebase #330
Comments
Can you show some code that you want to preserve, please?
Le mar. 30 avr. 2019 à 02:43, Maxim Naumov <notifications@github.com> a
écrit :
… I use Firebase Dynamic Links in my project. Turning ProGuard on caused
FirebaseDynamicLinks.getInstance() to return null. After some digging it
turned out that smoothie module was the cause.
At first removing this line seemed to help:
-adaptclassstrings
But I didn't want to remove smoothie from my project so I kept trying.
After a while I came up with a rule that worked for me:
-keep class * { @javax.inject.Qualifier <init>(...); }
Btw, not being a ProGuard expert I would expect this to work instead:
-keep @javax.inject.Qualifier class *
But it doesn't 🤷♂️.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#330>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAN7PXOREEED47UILQVY4HLPTAIDHANCNFSM4HJKAUVQ>
.
|
It's not my code I want to preserve. Instead, I want |
If I understand correctly,the qualifier annotation part is relevant to your
code.
If the option adaptclassstrings is impacting firebase, I would strongly
suggest that you open a ticket on their repo to ask them to document it.
TP might have required it for TP1 registries but I don't think it's needed
at all for TP2.
…On Wed., May 1, 2019, 09:06 Maxim Naumov, ***@***.***> wrote:
It's not my code I want to preserve. Instead, I want
FirebaseDynamicLinks.getInstance() to return a non-null value. As to why
that rule works or how it affects Firebase, no clue. I discovered it
accidentaly, basically. But it suddenly works so I'll just stick with it
until a better solution is found.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#330 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAN7PXOIF5NZ3LMKJ7X3WSLPTG5ZBANCNFSM4HJKAUVQ>
.
|
I couldn't find the Firebase Dynamic Links repo, this part of Firebase seems to be closed source. Anyway, I don't think it's a problem of Firebase. Because, isn't that rule too broad to be included in a library in the first place? And since it's not probably needed for TP2, could you consider removing it? |
A clean project test has shown that |
I've encountered a similar issue when updating from TP 1.1.1 to 2.1.0.
where |
Also, I had to modify the ProGuard rules to have it working in my project with 2.x.
had to be changed to
and I had to add
|
The wiki has been updated. I close this oooolllddd ticket. Sorry about that @ultimate-deej |
I use Firebase Dynamic Links in my project. Turning ProGuard on caused
FirebaseDynamicLinks.getInstance()
to returnnull
. After some digging it turned out that smoothie module was the cause.At first removing this line seemed to help:
-adaptclassstrings
But I didn't want to remove smoothie from my project so I kept trying. After a while I came up with a rule that worked for me:
-keep class * { @javax.inject.Qualifier <init>(...); }
Btw, not being a ProGuard expert I would expect this to work instead:
-keep @javax.inject.Qualifier class *
But it doesn't 🤷♂️.
The text was updated successfully, but these errors were encountered: