Update ProGuard rules for Toothpick 3.0 and KTP

[zawadz88]

Hi,
I'm migrating from TP 2.1.0 to TP 3.0 and I've noticed that some ProGuard rules need updating if you're using @InjectConstructor and KTP delegates instead of @Inject-annotated properties. I didn't find any info about this in the documentation so I'm posting it here.

The following seems to be working for me:

-keepnames @toothpick.InjectConstructor class *
-keepclasseswithmembernames class * { toothpick.ktp.delegate.* *; }
-keepclassmembers class * {
    toothpick.ktp.delegate.* *;
}

in addition to already defined rules. Note: I'm using that on top of the rules mentioned in #330

[stephanenicolas]

Thx Piotr, we should update the wiki with this info.

…

On Mon, Sep 16, 2019, 23:53 Piotr Zawadzki, ***@***.***> wrote: Hi, I'm migrating from TP 2.1.0 to TP 3.0 and I've noticed that some ProGuard rules need updating if you're using @InjectConstructor and KTP delegates instead of @Inject-annotated properties. I didn't find any info about this in the documentation so I'm posting it here. The following seems to be working for me: -keepnames @toothpick.InjectConstructor class * -keepclasseswithmembernames class * { toothpick.ktp.delegate.* *; } -keepclassmembers class * { toothpick.ktp.delegate.* *; } in addition to already defined rules. Note: I'm using that on top of the rules mentioned in #330 <#330> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#370?email_source=notifications&email_token=AAN7PXPBEY5CVRQ6NGSYEIDQKB5FRA5CNFSM4IXLSQYKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HLYQFCA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN7PXOQIVE22HXLSLM3ZHDQKB5FRANCNFSM4IXLSQYA> .

[stephanenicolas]

@zawadz88 can you make a PR on the proguard file that TP passes to downstream projects please ? I have updated the docs already: https://github.com/stephanenicolas/toothpick/wiki/Proguard-&-TP

[dimsuz]

By the way, are there any plans to put proguard rules inside the library jar's resources? Android's new shrinker R8 (now default) supports this, so even clients who do not use smoothie will receive them, no need for manual addition and supporting wiki page. Moshi, okhttp, retrofit use this feature, it's working great.

Maybe I'll create a PR one day, but currently rather busy, so at least keep this in mind, iirc this isn't a complex thing to do.

[zawadz88]

@stephanenicolas I'll try to prepare something within a week :)

[stephanenicolas]

Thx Piotr, take your time, as we wanna merge also another PR with this one and release. But thx for doing it, S.

…

On Tue, Sep 24, 2019, 03:36 Piotr Zawadzki, ***@***.***> wrote: @stephanenicolas <https://github.com/stephanenicolas> I'll try to prepare something within a week :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#370?email_source=notifications&email_token=AAN7PXMARRUJV5CYFZ3RP63QLHUULA5CNFSM4IXLSQYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7N47BA#issuecomment-534499204>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAN7PXMZGK3AIJS4KMQULWTQLHUULANCNFSM4IXLSQYA> .

[stephanenicolas]

This has been addressed.

[RumataEstorish]

When migrating to gradle plugin 7.0 had to add
-keep @javax.inject.Qualifier public class *
to keep qualifiers working