merge master #10
Merged
merge master #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(plugin-chart-pivot-table): enable cross filtering * Fix test * Fix tests * Replace `.toEqual` with `.toMatchObject` to fix test * Use jest.fn() to mock setDataMask * Code review changes * Bring back setting ownState
* initial * tests added,1 typing issue present * remove log * remove color * remove duplicate tooltip * Update plugins/plugin-chart-echarts/src/Tree/transformProps.ts Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> * clean * merge * optional name column,more tests... * bug fix * remove unused imports * lint * bug fix * tying fix * clean,typing fix * stories added * optional metric control * bigger thumbnail * optional root node name * storybokk updated * children list seperated instead of mutating data,if root node not provided defaault it to node with most children * remove logs,optimization needed * find best node if root not provided,use seperate children list to avoid issues if column name is children * remove unused import * type fix * Update transformProps.ts * Update debugging.md * better todo * updated radio button with new signature Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
stephenLYZ
pushed a commit
that referenced
this pull request
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal