Error handling #413
Closed
Error handling #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses WAL mode to support multiple reads and a single writer.
Allows customizing new connections once created
ConnectionType is now Connection and Connection is now DBConnection
vfs seems to be a more reliable handling of exclusive mode.
Was using incorrect dispatch_once token.
# Conflicts: # SQLiteTests/ConnectionPoolTests.swift
Most fatalErrors have been replaced with proper Swift error handling. Aside from being more "correct" Swift code this also allows errors during binding to be thrown from external code and handled in places like custom function invocation.
It didn't make a lot of sense to being requiring `try` when calling operators that were building queries. Other functions like `scalar` and `pluck` are now correctly throwing errors
Closed
|
What is the state of this PR? I am hitting the issue in #430 and cant use the library because of this. Can I help somehow? |
|
#411 has merged. Is this one ready to be finished? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retreats from the use of
fatalErrorto report most errors and takes up the Swift error handling mechanism. Found being able to throw errors extremely useful when writing custom binding code (e.g. external implementations of Value).Not sure this PR is complete yet. Wanted to give an early look to see your thoughts. It piggybacks on my connection_pool branch/PR at the moment.