Throw an error occurred inside Query.pluck() #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -955,7 +955,10 @@ extension Connection { | |||
| } | |||
|
|
|||
| public func pluck(query: QueryType) -> Row? { | |||
| return try! prepare(query.limit(1, query.clauses.limit?.offset)).generate().next() | |||
| guard let rows = try? prepare(query.limit(1, query.clauses.limit?.offset)) else { | |||
| return nil | |||
There was a problem hiding this comment.
We should probably propagate the error up instead of returning nil.
There was a problem hiding this comment.
So basically I think this should be
public func pluck(query: QueryType) throws -> Row? {
return try prepare(query.limit(1, query.clauses.limit?.offset)).generate().next()
}
tasanobu-zz
changed the title
|
@nickmshelley |
|
Thanks @tasanobu! @stephencelis I'd love to see this merged when you get some time. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue reported in #414 to avoid app crash.