Merging old code #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial RhythmOne Prebid Server Adapter * Updated UserSync URL * Fixed gofmt issue * Code review comments updated, UserSync URL updated * Updated code based on review comments - Removed unused client parameter in NewRhythmoneBidder method * Incorporated review comments * Updated adapter with resolved conflict
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet.
* Started adding some code to validate the amp ext, and some unit tests which dont pass yet. * Fixed some bugs. Added more tests. * Updated the docs. * Fixed some tests... but not all. * Fixed last remaining bug. * Moved setAmpExt to the amp_auction file.
* Enables proper processing for deprecated (disabled) bidders. * Fixes PR identified issues
* Removed some of the 1.11 hacks and updated Travis to use Go 1.11.1. * Made a note about Go 1.11 tests in the docs.
* Fixes deprecated bidders not being removed from request.imp.ext * Removed a stray Printf * Removed unused import
* Initial work on default aliases * Adds test aliases file * adds tests for default aliases * Increases scope to a general default request * Update docs/developers/default-request.md Co-Authored-By: hhhjort <hhjort@appnexus.com> * Removes duplicate test * Resolves more PR comments * Missed a SetDefault() chnage
This CL introduces a mechanism to fetch currencies rates periodically from a remote source. Those rates are stored in `CurrencyConverter` struct which can be injected in PBS to get rates. This doesn't introduce any changes in PBS workflow just yet. It also address issues described in #722 regarding httptestClient overload in tests generating errors while running `validate.sh` script. Issue: #280
…as formated differently. I just did a fresh clone from origin, and redid my trivial change in beachfront.go. A diff with origin now looks right. (#731)
* Move user syncs to each respective adapter directory Add internal/testutil package * Update usersync tests to use testify's assert * Update syncer tests * Add ix and rhythmone usersyncs * Remove syncer_test.go
#732) * patches the beachfront usersyncer to not return a URL when none is configured. * Supresses sending a usersync for a syncer with no URL
…d sizes (#725) * Update ix adapter to make multiple bid requests for multiple slots and sizes * Change string typecasting * fix race condition * refactor to minimize a race condition on slower machines
* Prevent Imps with duplicate IDs. * Added an initial capacity to the map.
* Adds support for generating imp.diaplaymanagerver for AppNexus * Adds tests and docs * Adds more docs, tests, and validation.
* Defined cookie sync URL in config, cleared deprecated comment in usersync * merged error message changees and a few changes to the beachfront contracts * found a big bug. I was accessing imp.Bidfloor (always 0) instead of the bidfloor in the beachfront extension * A few more questions commented in for Alex in the morning - probably to be deleted next commit * Updated a bit more with contracts and updated validation JSON. I also ran into a validation error in the core project which I think I can fix. I'll take a look at that and possibly open a seperate branch for it, issue and PR. * This gets the contract and usersyncs straight as well as validation. I think this is ready for a PR. I have not included the validation error that I noted in the core project - issue #740, but I can easily add it. * Switched endpoints to QA to push up and do some QA testing. * switched to iframe * removed device type * switched to http endpoints * added JS flag as true for all video requests * and back to https for video * switched back to production endpoints -ready for PR * ran validation again to get formating * fixed validation errors after Travis tests failed. In order to pass validation and put this PR in, I'm going to have to change user-ext-consent-int.json as per #740. * removed my naive fix for #740 as it's obviously wrong
* Brightroll auction type explicitly default to first price auction * fixed merge issue * removed unnessary code
* Check size match as per config before creating request * Make size optional in json validation config
* Add new bidder TTX (33Across) * - update ttx syncer and config * - update config for ttx bidder * - add condition for user sync redirect url * - update bidder name to 33across - add params requirement * - update method to "New33AcrossBidder" * - update base on feedback from dbemiller
* Updated the docker build docs. * Updated dockerfile maintainer.
* Added the timeout to the response. * Shorter property name... I think a bit better.
* gumgum adapter implementation * removing device info params since newest prebid client started sending over device info * secure endpoints for gumgum * removing app from gumgum bidder info
…me useless helper methods from the tests with testify. (#761)
This is on top of the changes from #993, which has not been merged, and this pretty much wraps up the major changes that we are doing for now. In addition to giving the titular choice, this makes a simple guess at device type and security.
* Refactoring cookie_sync.go * Couple of changes in exchange.go * Removed unnecessary TODO comment * Scott's Oct 15th comments * Scott's Oct 15th comments - part 2
* Get bidfloor value from ExtImp instead of Imp [#168939771] * Bump adapter version to 7 * Remove gzip encoding handling (not working)
* Add Timing Metrics For Prebid Cache * Defined new timer buckets for short PBC requests * Add Timing Metrics For Prebid Cache * Defined new timer buckets for short PBC requests * Merge Correctly * Merge Correctly 2 * Added Success/Failure Labels * Small Refactor
* Restrict /setuid for Prebid supported bidders only * Improve some test cases based on code review comments
* datablocks bid adapter * ttx * add test json * add coverage * redo ttx * formatted * better error handling * additional tests and recomended fixes
* Making IAB category translation optional with translatecategories boolean in request * Updating exchange unit tests to remove extra bids * Updates from code review comments * Removed comment about default TranslateCategories value * Changed translateCat to translateCategories in tests * Combined helper functions in exchange_test related to TranslateCategories
This detail was missed while setting up the adapter, but we would like to use https for the user sync.
* ignore swp files * start small * start really small * add a user sync * justify * triplelift adapter * add our endpoint * fix syntax * config stuff * compiler fixes * more config * add params * making progress * make our ext more exty * start making responses * more logic * fix compilation errors * can we just nil this out? * augment our json * radically simplify our json * fix errs * infer the bid type * fix syntax * fix comilation errors * rename * fix compilation error * config stuff * simplify params * more config stuff * fixes * revert this * fix up the extension * getting closer * add a test * update config * update bidder params * add the floor here, too * add a usersync test * validation, ws, and a test * update tests * fix test * update email * why not * change email * preprocess requests * do some parsing * take care of some errors * floor is optional * ws * remove native * everything is either banner or video * this should be a float * floor to floor * fix compilation errors * add some tests * more tests * more tests * simplify * more progress * format * ws * rm * don't need this * fix test * fix test * don't ignore swap * change line back * report an error if there are no valid impressions for triplelift * check for either a Banner or Video object on the impression * more tests * mv * more tests * update triplelift end point * send native * ws * start changing tests * fix more tests * update config * add redirect to triplelift usersync * fix supplier id in triplelift_test * update tl usersync endpoint and test * fix tl supplier id in test json * update usersync test template * adjust inconsistency with test and sync url * mv * update packages * mv * mv * update * fix compilation errors * rename * rename some stuff * rename * rename * fix some compilation errors * ws * ws * add the extra info * add some extra info * add some files back * ws and such * updates * ws * fix compilation error * mv * rename * Revert "rename" This reverts commit 1b77c72. * Revert "mv" This reverts commit 52a134d. * it builds * cp a file * cp another file * fix a test * fix test * add the extra info * ws * add some logic * edit comment * it compiles * this is now public * call this * add the function * return nil * seems to be working * ws * seems to be working * ws * mv * starting to work * ws * add a new function * ws * fix tests * bug fix * update some stuff * revert * take out prints * fix up diff * fix up diff * update ws * fix * ws * omit the triplelift endppint * Revert "omit the triplelift endppint" This reverts commit 7abc3e4. * populate the endpoint through the extinfo * ws * set disabled to be default * ws * update types * fixing tests * making progres * fix tests * fix tests * more fixes for tests * fixed tests * just use a comment * get rid of endpoint * restore endpoint * add some errors around unmarshalling * ws * ws * use the literal * ws * ws * update json * simplify * ws * restore tests * fail fast when grabbing invcode * use the right type * use a different error type * bump code coverage * add a new test * change error type * ws * break out test into its own function
stevealliance
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Pubstack Analytics V1 (prebid#11) * V1 Pubstack (prebid#7) * feat: Add Pubstack Logger (prebid#6) * first version of pubstack analytics * bypass viperconfig * commit #1 * gofmt * update configuration and make the tests pass * add readme on how to configure the adapter and update the network calls * update logging and fix intake url definition * feat: Pubstack Analytics Connector * fixing go mod * fix: bad behaviour on appending path to auction url * add buffering * support bootstyrap like configuration * implement route for all the objects * supports termination signal handling for goroutines * move readme to the correct location * wording * enable configuration reload + add tests * fix logs messages * fix tests * fix log line * conclude merge * merge * update go mod Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * fix duplicated channel keys Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * first pass - PR reviews * rename channel* -> eventChannel * dead code * Review (prebid#10) * use json.Decoder * update documentation * use nil instead []byte("") * clean code * do not use http.DefaultClient * fix race condition (need validation) * separate the sender and buffer logics * refactor the default configuration * remove error counter * Review GP + AR * updating default config * add more logs * remove alias fields in json * fix json serializer * close event channels Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * fix race condition * first pass (pr reviews) * refactor: store enabled modules into a dedicated struct * stop goroutine * test: improve coverage * PR Review * Revert "refactor: store enabled modules into a dedicated struct" This reverts commit f57d9d6. # Conflicts: # analytics/config/config_test.go Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.