Split Fortran2008.py into separate files (closes #411) #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupertford
added
in progress
F2008
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #425 +/- ##
==========================================
+ Coverage 91.81% 91.91% +0.10%
==========================================
Files 43 84 +41
Lines 13470 13625 +155
==========================================
+ Hits 12367 12524 +157
+ Misses 1103 1101 -2
☔ View full report in Codecov by Sentry. |
|
Ready for first review from @arporter or @sergisiso |
arporter
requested changes
Sep 11, 2023
There was a problem hiding this comment.
I've assumed that all you've done is move code to separate files so have not (well almost) requested changes to any of the content of those files.
However, I'm a bit worried by the splitparen shenanigans. Is it possible to get a handle on what's going wrong with that method?
arporter
added
reviewed with actions
rupertford
added
ready for review
and removed
reviewed with actions
|
You are correct that this PR simply splits out the classes from Fortran2008.py. Ready for next review from @arporter |
arporter
approved these changes
Sep 14, 2023
arporter
added
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits Fortran2008.py into one file per class.