Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

docs clarifying suggestions #288

Closed
erexer opened this issue Jan 27, 2023 · 2 comments
Closed

docs clarifying suggestions #288

erexer opened this issue Jan 27, 2023 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@erexer
Copy link

erexer commented Jan 27, 2023

  • the example my_script.py should include import sys
  • add a note that pip install sf-hamilton[visualization] needs to be pip install "sf-hamilton[visualization]" for zsh
  • doesn't work out of the box with python 3.11 (as far as I can tell), so the setup.py file might need to be changed
@skrawcz
Copy link
Collaborator

skrawcz commented Jan 27, 2023

Thanks for the issue @erexer !

Clarifying questions:

  • the example my_script.py should include import sys

can you link the file please? I can't seem to locate this. NVM: found this thanks. Fixed in #289

  • add a note that pip install sf-hamilton[visualization] needs to be pip install "sf-hamilton[visualization]" for zsh

Noted, thanks! Fixed in #289

  • doesn't work out of the box with python 3.11 (as far as I can tell), so the setup.py file might need to be changed

Do you have a stack trace? Otherwise we have #216 open if you wanted to add to it.

@skrawcz skrawcz self-assigned this Jan 28, 2023
@skrawcz skrawcz added the documentation Improvements or additions to documentation label Jan 28, 2023
skrawcz added a commit that referenced this issue Jan 28, 2023
Was missing import; flagged in #288.
skrawcz added a commit that referenced this issue Jan 28, 2023
Was missing import; flagged in #288.
@skrawcz
Copy link
Collaborator

skrawcz commented Jan 28, 2023

@erexer okay closing this -- and moving 3.11 support chat to #216 .

@skrawcz skrawcz closed this as completed Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants